From patchwork Fri Jul 26 00:56:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ralph Campbell X-Patchwork-Id: 11060115 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5504F1398 for ; Fri, 26 Jul 2019 00:57:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4522E28845 for ; Fri, 26 Jul 2019 00:57:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3905928A38; Fri, 26 Jul 2019 00:57:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0737128A15 for ; Fri, 26 Jul 2019 00:57:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02E158E0006; Thu, 25 Jul 2019 20:57:16 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id F221B8E0002; Thu, 25 Jul 2019 20:57:15 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D99C08E0006; Thu, 25 Jul 2019 20:57:15 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-yw1-f72.google.com (mail-yw1-f72.google.com [209.85.161.72]) by kanga.kvack.org (Postfix) with ESMTP id BC5E18E0002 for ; Thu, 25 Jul 2019 20:57:15 -0400 (EDT) Received: by mail-yw1-f72.google.com with SMTP id p18so38204127ywe.17 for ; Thu, 25 Jul 2019 17:57:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding:dkim-signature; bh=D2MJs2fZHD43Md8ZpV6DlNuTDZTSVoq5UF6AxcLBY88=; b=RJEQ8wvIoyU4fCkV0AbnJqpjhXo5AkGfJf/4eMqc+F9YkcZ60siEWDRLoC4KpVQ0PJ qXKYxr+EQvqw/371smYHKItH49hA3U8DDMLrPSR1lGJQ5sNTHj/CGMAhkeU2jEQrTRve rgiG8hNByvnypvbH4MrexIRd2qi3dbLv/guNq7MIwTZu8Kcl6GW6ZmvviYpMGlDYig6C 0EPk5Ve9JNNFJyMAL8BqMMsFYfJmIUpnk5OLIXsXqEUoKYZv6oWKyhsKiJZGrHqyfcQG HrcN2amqBqljCSR0AY5EMW0shst05bAM1iKgjoRMA2w3NyxsDH6oi1mdJjmrU4Z312yu 1jDg== X-Gm-Message-State: APjAAAWSYk9+i12X0z6y+wAzQwpq9eXaBC8clHTuWzVaOJlkdI/aD/bT 1IHQjLeJVt61rpESa6D3RbAQ8/XIhX+qozjrXy8cOhk1U5B9HLzVHqaVepfAF2HUAN+Sj6Bnv/z sLd693d/HM3fbTFCD09S0KJbIocJI/t6rzq0R2KCgVXF0bg14GkRfygJrBZ3jPuVriA== X-Received: by 2002:a81:50a:: with SMTP id 10mr54853457ywf.129.1564102635568; Thu, 25 Jul 2019 17:57:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzpeOs09SRNYmukTHel+ubCL2qqgVO5+lyl06ekIC3w8Y/830Z7slTV/wKosRo3B/h5V7d4 X-Received: by 2002:a81:50a:: with SMTP id 10mr54853444ywf.129.1564102635076; Thu, 25 Jul 2019 17:57:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564102635; cv=none; d=google.com; s=arc-20160816; b=i6Rr1AE1M9HYZwzZG8oRReCknpMUnP/3Cy8w6A7V2oVj6/8mCWrQ+dlRagIDqNNPw0 P8gWcZ2iu0dkZtAgqVAbVjOiKqCXyhzp4Foway/pmnToNw+R5A+xUipwSW7Iq5m9aNpH +GAC/pH6e9mLqqb5pIzfC0KPOKsRdGxi11YO1gJVfxjlswMJhwnflHLTWjmmxeGlEXdK pfOE71fkIB1IxaZCZLtMZtcsWonc+ciTMlxdP6gVhioB0LWWIBp5KD/K5JNvZ3jqDAHw lOt+S1+L2BVBN5u0AKdX9QvJPPvDtQByA8199m3Nr5fHCpEaDGMC83kn/gvmACU3AOq+ Ml0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from; bh=D2MJs2fZHD43Md8ZpV6DlNuTDZTSVoq5UF6AxcLBY88=; b=F/v2OQTzt9rtbloXj8gK8KA7TrIj+q21fiTGEeMqpVwkjaW42FY4tLBfA9rI0alWp7 KzGywfXcGSR1ldbEN7OVpwkrkajxCiiZ26tOPYkCq47WdYFiXt+Ttd6stS0Y8KekBcq0 s4oeNp6SJZUq0qbB4ugiX2cbIM2++3bzFceFj8/LfPyc9EXIgohdOO+JSTmsKT2LConm UHe+QNxLZpbs5uiPIthuVhsDmpBa9PoBsYCwgKzIcA+9CQJuPaioIY+70QEeakqiFxmn MZ25cm8zqMDxhXIPS/+eRneZ+1rneLOTq4AUz0VLOLMu7/qCylml+EdEbMyQMkHKWrpb hK9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=dDhXdZ0f; spf=pass (google.com: domain of rcampbell@nvidia.com designates 216.228.121.143 as permitted sender) smtp.mailfrom=rcampbell@nvidia.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com. [216.228.121.143]) by mx.google.com with ESMTPS id h9si16330130ywb.114.2019.07.25.17.57.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 17:57:15 -0700 (PDT) Received-SPF: pass (google.com: domain of rcampbell@nvidia.com designates 216.228.121.143 as permitted sender) client-ip=216.228.121.143; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=dDhXdZ0f; spf=pass (google.com: domain of rcampbell@nvidia.com designates 216.228.121.143 as permitted sender) smtp.mailfrom=rcampbell@nvidia.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 25 Jul 2019 17:57:15 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 25 Jul 2019 17:57:14 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 25 Jul 2019 17:57:14 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL104.nvidia.com (172.18.146.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 26 Jul 2019 00:57:13 +0000 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 26 Jul 2019 00:57:08 +0000 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 26 Jul 2019 00:57:08 +0000 Received: from rcampbell-dev.nvidia.com (Not Verified[10.110.48.66]) by hqnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Thu, 25 Jul 2019 17:57:08 -0700 From: Ralph Campbell To: CC: , , , , "Ralph Campbell" , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Christoph Hellwig Subject: [PATCH v2 6/7] mm/hmm: remove hugetlbfs check in hmm_vma_walk_pmd Date: Thu, 25 Jul 2019 17:56:49 -0700 Message-ID: <20190726005650.2566-7-rcampbell@nvidia.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190726005650.2566-1-rcampbell@nvidia.com> References: <20190726005650.2566-1-rcampbell@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1564102635; bh=D2MJs2fZHD43Md8ZpV6DlNuTDZTSVoq5UF6AxcLBY88=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:X-NVConfidentiality: Content-Type:Content-Transfer-Encoding; b=dDhXdZ0fq+/bJJsVQCR7FJrU8TlXvz2itR9WvHA+D+zGwHRjQv48omdl45RnxXmpB lVwB46LJQ7I1jmYZq8f2HDTONx4QL6yNAHgoDlCDzhsrayuWPJZUlqCiHsvrejtQAo IzffaEtC6GLs+mrZgw+/TfanZcDKiKjQzJg6UcKUCcQzs0xxBR7vdmXnZdWx1QuO65 lsl3wTSKpIjNMBnruP2rDqPtA1oWApYCh1VuHm12T+FlHh0ONlL8rrfRqIuenKDf4H l85a/V9vbnHfXJYcg4Hz8fOoowAC4ZLQH9YSs7dtBwWkS9sagT3o5JY0D0Y19kfUqB dfO9F2MBE+xGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP walk_page_range() will only call hmm_vma_walk_hugetlb_entry() for hugetlbfs pages and doesn't call hmm_vma_walk_pmd() in this case. Therefore, it is safe to remove the check for vma->vm_flags & VM_HUGETLB in hmm_vma_walk_pmd(). Signed-off-by: Ralph Campbell Cc: "Jérôme Glisse" Cc: Jason Gunthorpe Cc: Christoph Hellwig Reviewed-by: Christoph Hellwig --- mm/hmm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index 838cd1d50497..29f322ca5d58 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -630,9 +630,6 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, if (pmd_none(pmd)) return hmm_vma_walk_hole(start, end, walk); - if (pmd_huge(pmd) && (range->vma->vm_flags & VM_HUGETLB)) - return hmm_pfns_bad(start, end, walk); - if (thp_migration_supported() && is_pmd_migration_entry(pmd)) { bool fault, write_fault; unsigned long npages;