| Message ID | 1564108975-27423-3-git-send-email-masonccyang@mxic.com.tw (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: Add Renesas R-Car Gen3 RPC-IF SPI driver | expand |
Hi Mason, Thanks for the update! On Fri, Jul 26, 2019 at 4:19 AM Mason Yang <masonccyang@mxic.com.tw> wrote: > Dcument the bindings used by the Renesas R-Car Gen3 RPC-IF controller. Document > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > Reviewed-by: Rob Herring <robh@kernel.org> > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > @@ -0,0 +1,46 @@ [...] > +- flash: should be represented by a subnode of the RPC-IF node, > + which "compatible" property contains "jedec,spi-nor", it presents > + SPI is used. Sorry, I failed to parse the last subsentence. > + > +Example: > + > + rpc: spi@ee200000 { > + compatible = "renesas,r8a77995-rpc", "renesas,rcar-gen3-rpc"; > + reg = <0 0xee200000 0 0x200>, <0 0x08000000 0 0x4000000>, > + <0 0xee208000 0 0x100>; > + reg-names = "regs", "dirmap", "wbuf"; > + clocks = <&cpg CPG_MOD 917>; > + clock-names = "rpc"; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 917>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <40000000>; > + spi-tx-bus-width = <1>; > + spi-rx-bus-width = <1>; Shouldn't those <1> be <4>, as this is QSPI? > + }; > + }; Gr{oetje,eeting}s, Geert
Hi Geert, > On Fri, Jul 26, 2019 at 4:19 AM Mason Yang <masonccyang@mxic.com.tw> wrote: > > Dcument the bindings used by the Renesas R-Car Gen3 RPC-IF controller. > > Document Oops, sorry ! > > > > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > > Reviewed-by: Rob Herring <robh@kernel.org> > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > > @@ -0,0 +1,46 @@ > > [...] > > > +- flash: should be represented by a subnode of the RPC-IF node, > > + which "compatible" property contains "jedec,spi-nor", it presents > > + SPI is used. > > Sorry, I failed to parse the last subsentence. Fix it to: - flash: should be represented by a subnode of the RPC-IF node, its "compatible" property contains "jedec,spi-nor" presents SPI is used. OK? > > > + > > +Example: > > + > > + rpc: spi@ee200000 { > > + compatible = "renesas,r8a77995-rpc", "renesas,rcar-gen3-rpc"; > > + reg = <0 0xee200000 0 0x200>, <0 0x08000000 0 0x4000000>, > > + <0 0xee208000 0 0x100>; > > + reg-names = "regs", "dirmap", "wbuf"; > > + clocks = <&cpg CPG_MOD 917>; > > + clock-names = "rpc"; > > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > > + resets = <&cpg 917>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + flash@0 { > > + compatible = "jedec,spi-nor"; > > + reg = <0>; > > + spi-max-frequency = <40000000>; > > + spi-tx-bus-width = <1>; > > + spi-rx-bus-width = <1>; > > Shouldn't those <1> be <4>, as this is QSPI? okay, fix them to <4> thanks for your time & review. best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
Hi Mason, On Mon, Jul 29, 2019 at 11:34 AM <masonccyang@mxic.com.tw> wrote: > > On Fri, Jul 26, 2019 at 4:19 AM Mason Yang <masonccyang@mxic.com.tw> > wrote: > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > > > @@ -0,0 +1,46 @@ > > > > [...] > > > > > +- flash: should be represented by a subnode of the RPC-IF node, > > > + which "compatible" property contains "jedec,spi-nor", it > presents > > > + SPI is used. > > > > Sorry, I failed to parse the last subsentence. > > > Fix it to: > - flash: should be represented by a subnode of the RPC-IF node, > its "compatible" property contains "jedec,spi-nor" presents > SPI is used. > > OK? s/presents/if/? Gr{oetje,eeting}s, Geert
Hi Geert, > On Mon, Jul 29, 2019 at 11:34 AM <masonccyang@mxic.com.tw> wrote: > > > On Fri, Jul 26, 2019 at 4:19 AM Mason Yang <masonccyang@mxic.com.tw> > > wrote: > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > > > > @@ -0,0 +1,46 @@ > > > > > > [...] > > > > > > > +- flash: should be represented by a subnode of the RPC-IF node, > > > > + which "compatible" property contains "jedec,spi-nor", it > > presents > > > > + SPI is used. > > > > > > Sorry, I failed to parse the last subsentence. > > > > > > Fix it to: > > - flash: should be represented by a subnode of the RPC-IF node, > > its "compatible" property contains "jedec,spi-nor" presents > > SPI is used. > > > > OK? > > s/presents/if/? > Got it, thanks for your correction. - flash: should be represented by a subnode of the RPC-IF node, its "compatible" property contains "jedec,spi-nor" if SPI is used. best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
diff --git a/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt new file mode 100644 index 0000000..d929850 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt @@ -0,0 +1,46 @@ +Renesas R-Car Gen3 RPC-IF controller Device Tree Bindings +--------------------------------------------------------- + +Required properties: +- compatible: should be an SoC-specific compatible value, followed by + "renesas,rcar-gen3-rpc" as a fallback. + supported SoC-specific values are: + "renesas,r8a77980-rpc" (R-Car V3H) + "renesas,r8a77995-rpc" (R-Car D3) +- reg: should contain three register areas: + first for the base address of RPC-IF registers, + second for the direct mapping read mode and + third for the write buffer area. +- reg-names: should contain "regs", "dirmap" and "wbuf" +- clocks: should contain the clock phandle/specifier pair for the module clock. +- clock-names: should contain "rpc" +- power-domains: should contain the power domain phandle/secifier pair. +- resets: should contain the reset controller phandle/specifier pair. +- #address-cells: should be 1 +- #size-cells: should be 0 +- flash: should be represented by a subnode of the RPC-IF node, + which "compatible" property contains "jedec,spi-nor", it presents + SPI is used. + +Example: + + rpc: spi@ee200000 { + compatible = "renesas,r8a77995-rpc", "renesas,rcar-gen3-rpc"; + reg = <0 0xee200000 0 0x200>, <0 0x08000000 0 0x4000000>, + <0 0xee208000 0 0x100>; + reg-names = "regs", "dirmap", "wbuf"; + clocks = <&cpg CPG_MOD 917>; + clock-names = "rpc"; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 917>; + #address-cells = <1>; + #size-cells = <0>; + + flash@0 { + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <40000000>; + spi-tx-bus-width = <1>; + spi-rx-bus-width = <1>; + }; + };