ci: install C++ in opensuse-leap CI container
diff mbox series

Message ID 156413540514.22784.14073005924861814163.stgit@Palanthas
State New, archived
Headers show
Series
  • ci: install C++ in opensuse-leap CI container
Related show

Commit Message

Dario Faggioli July 26, 2019, 10:03 a.m. UTC
The openSUSE Leap container image, built after
opensuse-leap.dockerfile was missing the gcc-c++,
which is necessary, e.g., for building OVMF.

Add it.

Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
---
Cc: Doug Goldstein <cardoe@cardoe.com>
---
 automation/build/suse/opensuse-leap.dockerfile |    1 +
 1 file changed, 1 insertion(+)

Comments

Doug Goldstein July 29, 2019, 5:18 p.m. UTC | #1
On 7/26/19 5:03 AM, Dario Faggioli wrote:

> The openSUSE Leap container image, built after
> opensuse-leap.dockerfile was missing the gcc-c++,
> which is necessary, e.g., for building OVMF.
>
> Add it.
>
> Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
> ---
> Cc: Doug Goldstein <cardoe@cardoe.com>
> ---


Acked-by: Doug Goldstein <cardoe@cardoe.com>

Will you be pushing the rebuilt container or do you need me to do that?
Dario Faggioli Aug. 2, 2019, noon UTC | #2
On Mon, 2019-07-29 at 12:18 -0500, Doug Goldstein wrote:
> On 7/26/19 5:03 AM, Dario Faggioli wrote:
> 
> > The openSUSE Leap container image, built after
> > opensuse-leap.dockerfile was missing the gcc-c++,
> > which is necessary, e.g., for building OVMF.
> > 
> > Add it.
> > 
> > Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
> > ---
> > Cc: Doug Goldstein <cardoe@cardoe.com>
> > ---
> 
> Acked-by: Doug Goldstein <cardoe@cardoe.com>
> 
Hey, sorry, I missed this mail. Thanks for the Ack.

> Will you be pushing the rebuilt container or do you need me to do
> that?
> 
I tried to push, but:

$ PUSH=1 make suse/opensuse-leap
docker build -t registry.gitlab.com/xen-project/xen/suse:opensuse-leap -f suse/opensuse-leap.dockerfile suse
Sending build context to Docker daemon  4.608kB
Step 1/7 : FROM opensuse/leap
 ---> dd4bf894d243
Step 2/7 : LABEL maintainer.name="The Xen Project"       maintainer.email="xen-devel@lists.xenproject.org"
...
...
...
Successfully built c78388ff370b
Successfully tagged registry.gitlab.com/xen-project/xen/suse:opensuse-leap
The push refers to repository [registry.gitlab.com/xen-project/xen/suse]
007cb8c7f305: Preparing 
b399fccb00f7: Preparing 
70ea1f18573b: Preparing 
2379cf7101e2: Preparing 
denied: requested access to the resource is denied
make: *** [Makefile:14: suse/opensuse-leap] Error 1

:-)

So, I guess someone else, with enough rights, would have to do that.

Or am I missing some auth step or aomething?

Thanks and Regards
Andrew Cooper Aug. 2, 2019, 12:11 p.m. UTC | #3
On 02/08/2019 13:00, Dario Faggioli wrote:
> On Mon, 2019-07-29 at 12:18 -0500, Doug Goldstein wrote:
>> On 7/26/19 5:03 AM, Dario Faggioli wrote:
>>
>>> The openSUSE Leap container image, built after
>>> opensuse-leap.dockerfile was missing the gcc-c++,
>>> which is necessary, e.g., for building OVMF.
>>>
>>> Add it.
>>>
>>> Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
>>> ---
>>> Cc: Doug Goldstein <cardoe@cardoe.com>
>>> ---
>> Acked-by: Doug Goldstein <cardoe@cardoe.com>
>>
> Hey, sorry, I missed this mail. Thanks for the Ack.
>
>> Will you be pushing the rebuilt container or do you need me to do
>> that?
>>
> I tried to push, but:
>
> $ PUSH=1 make suse/opensuse-leap
> docker build -t registry.gitlab.com/xen-project/xen/suse:opensuse-leap -f suse/opensuse-leap.dockerfile suse
> Sending build context to Docker daemon  4.608kB
> Step 1/7 : FROM opensuse/leap
>  ---> dd4bf894d243
> Step 2/7 : LABEL maintainer.name="The Xen Project"       maintainer.email="xen-devel@lists.xenproject.org"
> ...
> ...
> ...
> Successfully built c78388ff370b
> Successfully tagged registry.gitlab.com/xen-project/xen/suse:opensuse-leap
> The push refers to repository [registry.gitlab.com/xen-project/xen/suse]
> 007cb8c7f305: Preparing 
> b399fccb00f7: Preparing 
> 70ea1f18573b: Preparing 
> 2379cf7101e2: Preparing 
> denied: requested access to the resource is denied
> make: *** [Makefile:14: suse/opensuse-leap] Error 1
>
> :-)
>
> So, I guess someone else, with enough rights, would have to do that.
>
> Or am I missing some auth step or aomething?

You need to do a docker login to the registry.

See https://gitlab.com/help/user/project/container_registry

Then the push should work.

~Andrew
Dario Faggioli Aug. 2, 2019, 2:37 p.m. UTC | #4
On Fri, 2019-08-02 at 13:11 +0100, Andrew Cooper wrote:
> On 02/08/2019 13:00, Dario Faggioli wrote:
> > On Mon, 2019-07-29 at 12:18 -0500, Doug Goldstein wrote:
> > > 
> > > Will you be pushing the rebuilt container or do you need me to do
> > > that?
> >
> > So, I guess someone else, with enough rights, would have to do
> > that.
> > 
> > Or am I missing some auth step or aomething?
> 
> You need to do a docker login to the registry.
> 
> See https://gitlab.com/help/user/project/container_registry
> 
Ah, that's what I was missing!

> Then the push should work.
> 
Yes, it did work. The updated Leap container is online.

Thanks and Regards
Doug Goldstein Aug. 3, 2019, 2:36 p.m. UTC | #5
On 8/2/19 9:37 AM, Dario Faggioli wrote:

> On Fri, 2019-08-02 at 13:11 +0100, Andrew Cooper wrote:
>> On 02/08/2019 13:00, Dario Faggioli wrote:
>>> On Mon, 2019-07-29 at 12:18 -0500, Doug Goldstein wrote:
>>>> Will you be pushing the rebuilt container or do you need me to do
>>>> that?
>>> So, I guess someone else, with enough rights, would have to do
>>> that.
>>>
>>> Or am I missing some auth step or aomething?
>> You need to do a docker login to the registry.
>>
>> See https://gitlab.com/help/user/project/container_registry
>>
> Ah, that's what I was missing!
I'll submit a patch to update the docs to make this clear.

Patch
diff mbox series

diff --git a/automation/build/suse/opensuse-leap.dockerfile b/automation/build/suse/opensuse-leap.dockerfile
index 614a5c8405..a627c9a1f1 100644
--- a/automation/build/suse/opensuse-leap.dockerfile
+++ b/automation/build/suse/opensuse-leap.dockerfile
@@ -21,6 +21,7 @@  RUN zypper install -y \
         discount \
         flex \
         gcc \
+        gcc-c++ \
         gettext-tools \
         git \
         glib2-devel \