| Message ID | 20190726210854.6408-3-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen/percpu: Cleanup | expand |
On Fri, Jul 26, 2019 at 10:08:52PM +0100, Andrew Cooper wrote: > None of these headers use any PER_CPU() infrastructure. > > xen/rwlock.h however does, and picked it up transitively via xen/spinlock.h, > so include it properly. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Thanks.
On 29.07.2019 10:55, Roger Pau Monné wrote: > On Fri, Jul 26, 2019 at 10:08:52PM +0100, Andrew Cooper wrote: >> None of these headers use any PER_CPU() infrastructure. >> >> xen/rwlock.h however does, and picked it up transitively via xen/spinlock.h, >> so include it properly. >> >> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> > > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/include/asm-x86/i387.h b/xen/include/asm-x86/i387.h index 434a7761a5..a783549db9 100644 --- a/xen/include/asm-x86/i387.h +++ b/xen/include/asm-x86/i387.h @@ -12,7 +12,6 @@ #define __ASM_I386_I387_H #include <xen/types.h> -#include <xen/percpu.h> /* Byte offset of the stored word size within the FXSAVE area/portion. */ #define FPU_WORD_SIZE_OFFSET 511 diff --git a/xen/include/xen/multicall.h b/xen/include/xen/multicall.h index d0aa52009c..ac8238660a 100644 --- a/xen/include/xen/multicall.h +++ b/xen/include/xen/multicall.h @@ -5,7 +5,6 @@ #ifndef __XEN_MULTICALL_H__ #define __XEN_MULTICALL_H__ -#include <xen/percpu.h> #ifdef CONFIG_COMPAT #include <compat/xen.h> #endif diff --git a/xen/include/xen/rcupdate.h b/xen/include/xen/rcupdate.h index 3402eb5caf..13850865ed 100644 --- a/xen/include/xen/rcupdate.h +++ b/xen/include/xen/rcupdate.h @@ -33,7 +33,6 @@ #include <xen/cache.h> #include <xen/spinlock.h> -#include <xen/percpu.h> #include <xen/cpumask.h> #include <xen/preempt.h> diff --git a/xen/include/xen/rwlock.h b/xen/include/xen/rwlock.h index 35657c56c4..3dfea1ac2a 100644 --- a/xen/include/xen/rwlock.h +++ b/xen/include/xen/rwlock.h @@ -1,6 +1,7 @@ #ifndef __RWLOCK_H__ #define __RWLOCK_H__ +#include <xen/percpu.h> #include <xen/spinlock.h> #include <asm/atomic.h> diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index a811b73bf3..2c7415e23a 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -4,7 +4,6 @@ #include <asm/system.h> #include <asm/spinlock.h> #include <asm/types.h> -#include <xen/percpu.h> #ifndef NDEBUG struct lock_debug {
None of these headers use any PER_CPU() infrastructure. xen/rwlock.h however does, and picked it up transitively via xen/spinlock.h, so include it properly. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Jan Beulich <JBeulich@suse.com> CC: Wei Liu <wl@xen.org> CC: Roger Pau Monné <roger.pau@citrix.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Julien Grall <julien.grall@arm.com> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> --- xen/include/asm-x86/i387.h | 1 - xen/include/xen/multicall.h | 1 - xen/include/xen/rcupdate.h | 1 - xen/include/xen/rwlock.h | 1 + xen/include/xen/spinlock.h | 1 - 5 files changed, 1 insertion(+), 4 deletions(-)