| Message ID | 20190727142736.23188-2-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: rockchip: Cleanup style around assignment operator | expand |
Hi Krzysztof, Am Samstag, 27. Juli 2019, 16:27:36 CEST schrieb Krzysztof Kozlowski: > Fix DTC warning: > > arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4: > Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name please see the comment directly above the memory node on why that needs to stay that way. So no, we'll keep the veyron memory node as is. Heiko > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/arm/boot/dts/rk3288-veyron.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi > index 8fc8eac699bf..02243ff46a65 100644 > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi > @@ -18,7 +18,7 @@ > * The default coreboot on veyron devices ignores memory@0 nodes > * and would instead create another memory node. > */ > - memory { > + memory@0 { > device_type = "memory"; > reg = <0x0 0x0 0x0 0x80000000>; > }; >
On Sat, 27 Jul 2019 at 17:33, Heiko Stuebner <heiko@sntech.de> wrote: > > Hi Krzysztof, > > Am Samstag, 27. Juli 2019, 16:27:36 CEST schrieb Krzysztof Kozlowski: > > Fix DTC warning: > > > > arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4: > > Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name > > please see the comment directly above the memory node on why that needs > to stay that way. So no, we'll keep the veyron memory node as is. Damn it, I missed it. Best regards, Krzysztof
Am Sonntag, 28. Juli 2019, 13:38:43 CEST schrieb Krzysztof Kozlowski: > On Sat, 27 Jul 2019 at 17:33, Heiko Stuebner <heiko@sntech.de> wrote: > > > > Hi Krzysztof, > > > > Am Samstag, 27. Juli 2019, 16:27:36 CEST schrieb Krzysztof Kozlowski: > > > Fix DTC warning: > > > > > > arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4: > > > Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name > > > > please see the comment directly above the memory node on why that needs > > to stay that way. So no, we'll keep the veyron memory node as is. > > Damn it, I missed it. no worries :-)
diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi index 8fc8eac699bf..02243ff46a65 100644 --- a/arch/arm/boot/dts/rk3288-veyron.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi @@ -18,7 +18,7 @@ * The default coreboot on veyron devices ignores memory@0 nodes * and would instead create another memory node. */ - memory { + memory@0 { device_type = "memory"; reg = <0x0 0x0 0x0 0x80000000>; };
Fix DTC warning: arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm/boot/dts/rk3288-veyron.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)