| Message ID | 20190729000259.GA24022@embeddedor (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sdhci-s3c: Mark expected switch fall-through | expand |
On 29/07/19 3:02 AM, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe': > drivers/mmc/host/sdhci-s3c.c:613:19: warning: this statement may fall through [-Wimplicit-fallthrough=] > host->mmc->caps |= MMC_CAP_8_BIT_DATA; > drivers/mmc/host/sdhci-s3c.c:614:2: note: here > case 4: > ^~~~ > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-s3c.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index 8e4a8ba33f05..cefa0fb8cfde 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -611,6 +611,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev) > switch (pdata->max_width) { > case 8: > host->mmc->caps |= MMC_CAP_8_BIT_DATA; > + /* Fall through */ > case 4: > host->mmc->caps |= MMC_CAP_4_BIT_DATA; > break; >
On Mon, 29 Jul 2019 at 02:03, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe': > drivers/mmc/host/sdhci-s3c.c:613:19: warning: this statement may fall through [-Wimplicit-fallthrough=] > host->mmc->caps |= MMC_CAP_8_BIT_DATA; > drivers/mmc/host/sdhci-s3c.c:614:2: note: here > case 4: > ^~~~ > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-s3c.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index 8e4a8ba33f05..cefa0fb8cfde 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -611,6 +611,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev) > switch (pdata->max_width) { > case 8: > host->mmc->caps |= MMC_CAP_8_BIT_DATA; > + /* Fall through */ > case 4: > host->mmc->caps |= MMC_CAP_4_BIT_DATA; > break; > -- > 2.22.0 >
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 8e4a8ba33f05..cefa0fb8cfde 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -611,6 +611,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev) switch (pdata->max_width) { case 8: host->mmc->caps |= MMC_CAP_8_BIT_DATA; + /* Fall through */ case 4: host->mmc->caps |= MMC_CAP_4_BIT_DATA; break;
Mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe': drivers/mmc/host/sdhci-s3c.c:613:19: warning: this statement may fall through [-Wimplicit-fallthrough=] host->mmc->caps |= MMC_CAP_8_BIT_DATA; drivers/mmc/host/sdhci-s3c.c:614:2: note: here case 4: ^~~~ Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/mmc/host/sdhci-s3c.c | 1 + 1 file changed, 1 insertion(+)