From patchwork Mon Jul 29 07:47:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 11063383 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C813E13A4 for ; Mon, 29 Jul 2019 07:47:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA8E0286AD for ; Mon, 29 Jul 2019 07:47:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AE6B3286E0; Mon, 29 Jul 2019 07:47:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 562D2286AD for ; Mon, 29 Jul 2019 07:47:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nhv2gChpS+NVmxYYE/b1GCtTOsLCI1WG8VrU5gVSRyk=; b=KEJirmadDskpaE JWr//3nQ4j3BuiHA/5rvNMFsrtJt+PDuGLO56vdXynjRQ73sS4tqXS6jvcoZ3DGaEFljkIE0eJo36 qKLPv4eQbHNeXB+Fmb8DaWRksTD9PWPV/KndqPklleBhIV9MwSn8xWpyww1YZMtySq9Bx2+QBsqz+ pReUyQxq96rTA8GIjn1zv4oe2qPd+iWMkPb51NdtSVegR1fjYc06y0hyM6J2tt5oC7E0KcOUqQbp+ pJaAnpTfsHA9G8KNdGUMpYuvB6ZEuvxJoD6I7w7XX6DYalbiG03smVdTidCME1sCBuQoYm5sOysLi 4DQdBYAbUluWMvaQ58zg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs0Nq-000225-0Y; Mon, 29 Jul 2019 07:47:50 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hs0Nn-0001zl-64 for linux-rockchip@lists.infradead.org; Mon, 29 Jul 2019 07:47:48 +0000 Received: by mail-pf1-x444.google.com with SMTP id t16so27549452pfe.11 for ; Mon, 29 Jul 2019 00:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Wq6GJCz6OpwvPx36T+BmHN2obhM+vzYcJ0vK8rO0YF0=; b=fMgIoiW3ShlTeR49mIXtuaJOrS2+VvqAOtXphwDgXhjrczEtt3yomfLVy2IIfGHkeJ L5q2EZQ2xPSNZ6g1nTjLCME5LCBH7g+OA7JbsRNh2klcvFv3KewFW4DJ4paBFS0BCr88 MR9PIidsVH9QkmXSEHpq2N4detN75HSboL/fA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Wq6GJCz6OpwvPx36T+BmHN2obhM+vzYcJ0vK8rO0YF0=; b=N6pS9DpwRWrIFAR6gec+l09XyuoSu/U6ge8bnsi3QPIMaP0pu4PtWySEC+KX0xfHOF sCkI3o5zRm3JmHXMG7Kst259+0DOIriPcth4H6ZVVIZcNv8IvuCsLl8Ef8jM8BbPV9Xb fx1thEtYWhNGYm2HOCQghSigW6Ccz451mqRYYiympT2v0J2OgWmACQBWD69tXvvu4VX1 dXmhmlfu98GTJj2g1YvOFPF2vFjfcXTW4NJfjwabcvTMegU7E9zaF2jGSCT0f+xsPOJ6 WdtFVGT8z3XxwDBrBKsbKre0+LT/ZJfj5gKOiJFyML3Ie64QyGz+iWBBqQ5/37EXXsZR 9y2Q== X-Gm-Message-State: APjAAAVQKyizNw38ffax6qcWlM4YFdP7chpNmsZuQmjlsdwb+uT/kZcR /S+MR8W6AWc3FNzi5MfyqXeypA== X-Google-Smtp-Source: APXvYqx6jowZR9X/srplpGIul5M/Ov0Bf5aMwlX8osvQf4Szvil62gsF4lfHtsOmQ83IkCLxZfTqTw== X-Received: by 2002:a65:6547:: with SMTP id a7mr81906381pgw.65.1564386465884; Mon, 29 Jul 2019 00:47:45 -0700 (PDT) Received: from localhost.localdomain ([49.206.203.41]) by smtp.gmail.com with ESMTPSA id h14sm75723348pfq.22.2019.07.29.00.47.42 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 29 Jul 2019 00:47:45 -0700 (PDT) From: Jagan Teki To: Kever Yang , Simon Glass , Philipp Tomsich Subject: [PATCH 06/15] wdt: designware: Simplify is_enabled function Date: Mon, 29 Jul 2019 13:17:02 +0530 Message-Id: <20190729074711.16988-7-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190729074711.16988-1-jagan@amarulasolutions.com> References: <20190729074711.16988-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_004747_277318_635768F5 X-CRM114-Status: UNSURE ( 9.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, Chin Liang See , u-boot@lists.denx.de, Jagan Teki , Andy Shevchenko , linux-amarula@amarulasolutions.com, Akash Gajjar Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Right now the designware is_enabled function is using numeric number to check whether watchdog is enabled or not, so use register macro and check the same. Cc: Chin Liang See Cc: Andy Shevchenko Signed-off-by: Jagan Teki --- drivers/watchdog/designware_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/designware_wdt.c b/drivers/watchdog/designware_wdt.c index c668567c66..bd858f0608 100644 --- a/drivers/watchdog/designware_wdt.c +++ b/drivers/watchdog/designware_wdt.c @@ -45,9 +45,7 @@ static void designware_wdt_enable(void) static unsigned int designware_wdt_is_enabled(void) { - unsigned long val; - val = readl((CONFIG_DW_WDT_BASE + DW_WDT_CR)); - return val & 0x1; + return readl(CONFIG_DW_WDT_BASE + DW_WDT_CR) & DW_WDT_CR_RMOD_OFFSET; } #if defined(CONFIG_HW_WATCHDOG)