[v2] crypto: ccp - Log an error message when ccp-crypto fails to load
diff mbox series

Message ID 20190729125543.6255-1-gary.hook@amd.com
State Accepted
Delegated to: Herbert Xu
Headers show
Series
  • [v2] crypto: ccp - Log an error message when ccp-crypto fails to load
Related show

Commit Message

Gary R Hook July 29, 2019, 12:56 p.m. UTC
From: Gary R Hook <gary.hook@amd.com>

If there are no CCP devices on the system, ccp-crypto will not load.
Write a message to the system log clarifying the reason for the failure
of the modprobe operation

Signed-off-by: Gary R Hook <gary.hook@amd.com>
---

Changes since v1:
 - Add missing signed-off-by

 drivers/crypto/ccp/ccp-crypto-main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Herbert Xu Aug. 9, 2019, 6:10 a.m. UTC | #1
On Mon, Jul 29, 2019 at 12:56:08PM +0000, Hook, Gary wrote:
> From: Gary R Hook <gary.hook@amd.com>
> 
> If there are no CCP devices on the system, ccp-crypto will not load.
> Write a message to the system log clarifying the reason for the failure
> of the modprobe operation
> 
> Signed-off-by: Gary R Hook <gary.hook@amd.com>
> ---
> 
> Changes since v1:
>  - Add missing signed-off-by
> 
>  drivers/crypto/ccp/ccp-crypto-main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Patch applied.  Thanks.

Patch
diff mbox series

diff --git a/drivers/crypto/ccp/ccp-crypto-main.c b/drivers/crypto/ccp/ccp-crypto-main.c
index 818096490829..8ee4cb45a3f3 100644
--- a/drivers/crypto/ccp/ccp-crypto-main.c
+++ b/drivers/crypto/ccp/ccp-crypto-main.c
@@ -405,8 +405,10 @@  static int ccp_crypto_init(void)
 	int ret;
 
 	ret = ccp_present();
-	if (ret)
+	if (ret) {
+		pr_err("Cannot load: there are no available CCPs\n");
 		return ret;
+	}
 
 	spin_lock_init(&req_queue_lock);
 	INIT_LIST_HEAD(&req_queue.cmds);