[4/6] iomap: warn on inline maps in iomap_writepage_map
diff mbox series

Message ID 156444948583.2682261.16607334257055353357.stgit@magnolia
State Superseded
Headers show
  • iomap: lift the xfs writepage code into iomap
Related show

Commit Message

Darrick J. Wong July 30, 2019, 1:18 a.m. UTC
From: Christoph Hellwig <hch@lst.de>

And inline mapping should never mark the page dirty and thus never end up
in writepages.  Add a check for that condition and warn if it happens.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
 fs/iomap/buffered-io.c |    2 ++
 1 file changed, 2 insertions(+)

diff mbox series

diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 21b50e8cb9f2..ed694a59c527 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -1405,6 +1405,8 @@  iomap_writepage_map(struct iomap_writepage_ctx *wpc,
 		error = wpc->ops->map_blocks(wpc, inode, file_offset);
 		if (error)
+		if (WARN_ON_ONCE(wpc->iomap.type == IOMAP_INLINE))
+			continue;
 		if (wpc->iomap.type == IOMAP_HOLE)
 		iomap_add_to_ioend(inode, file_offset, page, iop, wpc, wbc,