diff mbox series

[1/2] drm/i915/oa: add content to Makefile

Message ID 20190730102824.9434-1-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/2] drm/i915/oa: add content to Makefile | expand

Commit Message

Jani Nikula July 30, 2019, 10:28 a.m. UTC
Apparently the empty Makefile has caused some confusion. Add the
subdir-cc-flags-y as in 7fcc7ca549d4 ("drm/i915: add header search path
to subdir Makefiles") which should be useful.

The generated headers still aren't self-contained, so can't add that.

References: http://marc.info/?i=80bf2204-558a-6d3f-c493-bf17b891fc8a@infradead.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

---

This should fix the kernel header generation:
https://github.com/rib/gputop/pull/203
---
 drivers/gpu/drm/i915/oa/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jani Nikula July 30, 2019, 11:36 a.m. UTC | #1
On Tue, 30 Jul 2019, Jani Nikula <jani.nikula@intel.com> wrote:
> Apparently the empty Makefile has caused some confusion. Add the
> subdir-cc-flags-y as in 7fcc7ca549d4 ("drm/i915: add header search path
> to subdir Makefiles") which should be useful.
>
> The generated headers still aren't self-contained, so can't add that.
>
> References: http://marc.info/?i=80bf2204-558a-6d3f-c493-bf17b891fc8a@infradead.org
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> This should fix the kernel header generation:
> https://github.com/rib/gputop/pull/203

Now that Lionel helpfully merged that, I updated the series with a patch
addressing the generated headers as well. New series at
https://patchwork.freedesktop.org/series/64427/

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/oa/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/oa/Makefile b/drivers/gpu/drm/i915/oa/Makefile
> index e69de29bb2d1..256bfde4a287 100644
> --- a/drivers/gpu/drm/i915/oa/Makefile
> +++ b/drivers/gpu/drm/i915/oa/Makefile
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: MIT
> +
> +# For building individual subdir files on the command line
> +subdir-ccflags-y += -I$(srctree)/$(src)/..
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/oa/Makefile b/drivers/gpu/drm/i915/oa/Makefile
index e69de29bb2d1..256bfde4a287 100644
--- a/drivers/gpu/drm/i915/oa/Makefile
+++ b/drivers/gpu/drm/i915/oa/Makefile
@@ -0,0 +1,4 @@ 
+# SPDX-License-Identifier: MIT
+
+# For building individual subdir files on the command line
+subdir-ccflags-y += -I$(srctree)/$(src)/..