[PATCH/RFC] ARM: dts: rza2mevb: Fix numbering of Ethernet aliases
diff mbox series

Message ID 20190731133936.18228-1-geert+renesas@glider.be
State Under Review
Delegated to: Geert Uytterhoeven
Headers show
Series
  • [PATCH/RFC] ARM: dts: rza2mevb: Fix numbering of Ethernet aliases
Related show

Commit Message

Geert Uytterhoeven July 31, 2019, 1:39 p.m. UTC
The two Ethernet ports on the RZA2MEVB development board are labeled
"Ether1" and "Ether2".  Reflect this numbering in the ethernet aliases.

Fixes: eb8be0276d903a23 ("ARM: dts: rza2mevb: add ethernet aliases")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Is this the right thing to do?
Can U-Boot live with the absence of ethernet0?

 arch/arm/boot/dts/r7s9210-rza2mevb.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chris Brandt July 31, 2019, 2:28 p.m. UTC | #1
Hi Geert,

On Wed, Jul 31, 2019, Geert Uytterhoeven wrote:
> The two Ethernet ports on the RZA2MEVB development board are labeled
> "Ether1" and "Ether2".  Reflect this numbering in the ethernet aliases.

However, the channels are labeled as ETHERC0 and ETHERC1 in the hardware
manual.

So I guess my question is, in general, is the board specific Device Tree
supposed to describe what is on the SoC? Or on the board silk screen?

Maybe this is like "COM1" is labeled on PC motherboard and we expect it 
to show up as /dev/ttyS0 regardless of what physical serial port it is 
connected to.

Thanks,
Chris
Geert Uytterhoeven July 31, 2019, 3:02 p.m. UTC | #2
Hi Chris,

On Wed, Jul 31, 2019 at 4:28 PM Chris Brandt <Chris.Brandt@renesas.com> wrote:
> On Wed, Jul 31, 2019, Geert Uytterhoeven wrote:
> > The two Ethernet ports on the RZA2MEVB development board are labeled
> > "Ether1" and "Ether2".  Reflect this numbering in the ethernet aliases.
>
> However, the channels are labeled as ETHERC0 and ETHERC1 in the hardware
> manual.
>
> So I guess my question is, in general, is the board specific Device Tree
> supposed to describe what is on the SoC? Or on the board silk screen?

AFAIK the aliases numbering is supposed to match the board or case labels.

> Maybe this is like "COM1" is labeled on PC motherboard and we expect it
> to show up as /dev/ttyS0 regardless of what physical serial port it is
> connected to.

Those pesky FORTRAN programmers, counting from 1 ;-)

On Koelsch (and Salvator-X(S)), they are called "debug0" and "debug1".

These used to be /dev/ttySC6 and /dev/ttySC7, but got renamed in
commit 1f75cdac773bc9c9 ("ARM: shmobile: koelsch: Rename SCIF[01] serial
ports to ttySC[01]").

Gr{oetje,eeting}s,

                        Geert

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/r7s9210-rza2mevb.dts b/arch/arm/boot/dts/r7s9210-rza2mevb.dts
index d062d02865e7dfbb..0686bac4bfd8e191 100644
--- a/arch/arm/boot/dts/r7s9210-rza2mevb.dts
+++ b/arch/arm/boot/dts/r7s9210-rza2mevb.dts
@@ -18,8 +18,8 @@ 
 
 	aliases {
 		serial0 = &scif4;
-		ethernet0 = &ether0;
-		ethernet1 = &ether1;
+		ethernet1 = &ether0;
+		ethernet2 = &ether1;
 	};
 
 	chosen {