diff mbox series

[v4,2/2] dt-bindings: iio: potentiometer: add max5432.yaml binding

Message ID 20190731140706.2765-2-martin@kaiser.cx (mailing list archive)
State New, archived
Headers show
Series [v4,1/2] iio: potentiometer: add a driver for Maxim 5432-5435 | expand

Commit Message

Martin Kaiser July 31, 2019, 2:07 p.m. UTC
Add a binding for the Maxim Integrated MAX5432-MAX5435 family of digital
potentiometers.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v4
 - fix the dt bindings
   - replace ic20 with i2c
   - document the reg property
   - add additionalProperties and required

changes in v3
 - split dt bindings and driver code into separate patches
 - use yaml format for dt bindings
 - fix formatting of parameter lists

changes in v2
 - use MAX5432_ prefix for all defines
 - fix indentation
 - convert void * to unsigned long, not to u32
   (warning from kbuild test robot)

 .../bindings/iio/potentiometer/max5432.yaml        | 44 ++++++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/max5432.yaml

Comments

Rob Herring July 31, 2019, 4:50 p.m. UTC | #1
On Wed, Jul 31, 2019 at 8:07 AM Martin Kaiser <martin@kaiser.cx> wrote:
>
> Add a binding for the Maxim Integrated MAX5432-MAX5435 family of digital
> potentiometers.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> changes in v4
>  - fix the dt bindings
>    - replace ic20 with i2c
>    - document the reg property
>    - add additionalProperties and required
>
> changes in v3
>  - split dt bindings and driver code into separate patches
>  - use yaml format for dt bindings
>  - fix formatting of parameter lists
>
> changes in v2
>  - use MAX5432_ prefix for all defines
>  - fix indentation
>  - convert void * to unsigned long, not to u32
>    (warning from kbuild test robot)
>
>  .../bindings/iio/potentiometer/max5432.yaml        | 44 ++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/max5432.yaml

Reviewed-by: Rob Herring <robh@kernel.org>
Jonathan Cameron Aug. 5, 2019, 1:32 p.m. UTC | #2
On Wed, 31 Jul 2019 10:50:36 -0600
Rob Herring <robh+dt@kernel.org> wrote:

> On Wed, Jul 31, 2019 at 8:07 AM Martin Kaiser <martin@kaiser.cx> wrote:
> >
> > Add a binding for the Maxim Integrated MAX5432-MAX5435 family of digital
> > potentiometers.
> >
> > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> > ---
> > changes in v4
> >  - fix the dt bindings
> >    - replace ic20 with i2c
> >    - document the reg property
> >    - add additionalProperties and required
> >
> > changes in v3
> >  - split dt bindings and driver code into separate patches
> >  - use yaml format for dt bindings
> >  - fix formatting of parameter lists
> >
> > changes in v2
> >  - use MAX5432_ prefix for all defines
> >  - fix indentation
> >  - convert void * to unsigned long, not to u32
> >    (warning from kbuild test robot)
> >
> >  .../bindings/iio/potentiometer/max5432.yaml        | 44 ++++++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/max5432.yaml  
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Thanks,

Jonathan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/potentiometer/max5432.yaml b/Documentation/devicetree/bindings/iio/potentiometer/max5432.yaml
new file mode 100644
index 000000000000..5082f919df2a
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/potentiometer/max5432.yaml
@@ -0,0 +1,44 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/potentiometer/max5432.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim Integrated MAX5432-MAX5435 Digital Potentiometers
+
+maintainers:
+  - Martin Kaiser <martin@kaiser.cx>
+
+description: |
+  Maxim Integrated MAX5432-MAX5435 Digital Potentiometers connected via I2C
+
+  Datasheet:
+    https://datasheets.maximintegrated.com/en/ds/MAX5432-MAX5435.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max5432
+      - maxim,max5433
+      - maxim,max5434
+      - maxim,max5435
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      max5434@28 {
+        compatible = "maxim,max5434";
+        reg = <0x28>;
+      };
+    };