ALSA: isa/wavefront: remove redundant assignment to pointer bptr
diff mbox series

Message ID 20190801162824.32217-1-colin.king@canonical.com
State New
Headers show
Series
  • ALSA: isa/wavefront: remove redundant assignment to pointer bptr
Related show

Commit Message

Colin King Aug. 1, 2019, 4:28 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

The pointer bptr is being assigned a value that is never read
and it is being updated in the next statement with a new value.
The initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/isa/wavefront/wavefront_synth.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Takashi Iwai Aug. 2, 2019, 5:48 a.m. UTC | #1
On Thu, 01 Aug 2019 18:28:24 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> The pointer bptr is being assigned a value that is never read
> and it is being updated in the next statement with a new value.
> The initialization is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.


Takashi

Patch
diff mbox series

diff --git a/sound/isa/wavefront/wavefront_synth.c b/sound/isa/wavefront/wavefront_synth.c
index aec1c46e6697..c5b1d5900eed 100644
--- a/sound/isa/wavefront/wavefront_synth.c
+++ b/sound/isa/wavefront/wavefront_synth.c
@@ -788,7 +788,6 @@  wavefront_send_patch (snd_wavefront_t *dev, wavefront_patch_info *header)
 
 	dev->patch_status[header->number] |= WF_SLOT_FILLED;
 
-	bptr = buf;
 	bptr = munge_int32 (header->number, buf, 2);
 	munge_buf ((unsigned char *)&header->hdr.p, bptr, WF_PATCH_BYTES);