| Message ID | 20190802022005.5117-21-jhubbard@nvidia.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | put_user_pages(): miscellaneous call sites | expand |
On 02.08.19 04:19, john.hubbard@gmail.com wrote: > From: John Hubbard <jhubbard@nvidia.com> > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: xen-devel@lists.xenproject.org > Signed-off-by: John Hubbard <jhubbard@nvidia.com> > --- > drivers/xen/gntdev.c | 5 +---- > drivers/xen/privcmd.c | 7 +------ > 2 files changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c > index 4c339c7e66e5..2586b3df2bb6 100644 > --- a/drivers/xen/gntdev.c > +++ b/drivers/xen/gntdev.c > @@ -864,10 +864,7 @@ static int gntdev_get_page(struct gntdev_copy_batch *batch, void __user *virt, > > static void gntdev_put_pages(struct gntdev_copy_batch *batch) > { > - unsigned int i; > - > - for (i = 0; i < batch->nr_pages; i++) > - put_page(batch->pages[i]); > + put_user_pages(batch->pages, batch->nr_pages); > batch->nr_pages = 0; > } > > diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c > index 2f5ce7230a43..29e461dbee2d 100644 > --- a/drivers/xen/privcmd.c > +++ b/drivers/xen/privcmd.c > @@ -611,15 +611,10 @@ static int lock_pages( > > static void unlock_pages(struct page *pages[], unsigned int nr_pages) > { > - unsigned int i; > - > if (!pages) > return; > > - for (i = 0; i < nr_pages; i++) { > - if (pages[i]) > - put_page(pages[i]); > - } > + put_user_pages(pages, nr_pages); You are not handling the case where pages[i] is NULL here. Or am I missing a pending patch to put_user_pages() here? Juergen
On 8/1/19 9:36 PM, Juergen Gross wrote: > On 02.08.19 04:19, john.hubbard@gmail.com wrote: >> From: John Hubbard <jhubbard@nvidia.com> ... >> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c >> index 2f5ce7230a43..29e461dbee2d 100644 >> --- a/drivers/xen/privcmd.c >> +++ b/drivers/xen/privcmd.c >> @@ -611,15 +611,10 @@ static int lock_pages( >> static void unlock_pages(struct page *pages[], unsigned int nr_pages) >> { >> - unsigned int i; >> - >> if (!pages) >> return; >> - for (i = 0; i < nr_pages; i++) { >> - if (pages[i]) >> - put_page(pages[i]); >> - } >> + put_user_pages(pages, nr_pages); > > You are not handling the case where pages[i] is NULL here. Or am I > missing a pending patch to put_user_pages() here? > Hi Juergen, You are correct--this no longer handles the cases where pages[i] is NULL. It's intentional, though possibly wrong. :) I see that I should have added my standard blurb to this commit description. I missed this one, but some of the other patches have it. It makes the following, possibly incorrect claim: "This changes the release code slightly, because each page slot in the page_list[] array is no longer checked for NULL. However, that check was wrong anyway, because the get_user_pages() pattern of usage here never allowed for NULL entries within a range of pinned pages." The way I've seen these page arrays used with get_user_pages(), things are either done single page, or with a contiguous range. So unless I'm missing a case where someone is either a) releasing individual pages within a range (and thus likely messing up their count of pages they have), or b) allocating two gup ranges within the same pages[] array, with a gap between the allocations, ...then it should be correct. If so, then I'll add the above blurb to this patch's commit description. If that's not the case (both here, and in 3 or 4 other patches in this series, then as you said, I should add NULL checks to put_user_pages() and put_user_pages_dirty_lock(). thanks,
On 02.08.19 07:48, John Hubbard wrote: > On 8/1/19 9:36 PM, Juergen Gross wrote: >> On 02.08.19 04:19, john.hubbard@gmail.com wrote: >>> From: John Hubbard <jhubbard@nvidia.com> > ... >>> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c >>> index 2f5ce7230a43..29e461dbee2d 100644 >>> --- a/drivers/xen/privcmd.c >>> +++ b/drivers/xen/privcmd.c >>> @@ -611,15 +611,10 @@ static int lock_pages( >>> static void unlock_pages(struct page *pages[], unsigned int nr_pages) >>> { >>> - unsigned int i; >>> - >>> if (!pages) >>> return; >>> - for (i = 0; i < nr_pages; i++) { >>> - if (pages[i]) >>> - put_page(pages[i]); >>> - } >>> + put_user_pages(pages, nr_pages); >> >> You are not handling the case where pages[i] is NULL here. Or am I >> missing a pending patch to put_user_pages() here? >> > > Hi Juergen, > > You are correct--this no longer handles the cases where pages[i] > is NULL. It's intentional, though possibly wrong. :) > > I see that I should have added my standard blurb to this > commit description. I missed this one, but some of the other patches > have it. It makes the following, possibly incorrect claim: > > "This changes the release code slightly, because each page slot in the > page_list[] array is no longer checked for NULL. However, that check > was wrong anyway, because the get_user_pages() pattern of usage here > never allowed for NULL entries within a range of pinned pages." > > The way I've seen these page arrays used with get_user_pages(), > things are either done single page, or with a contiguous range. So > unless I'm missing a case where someone is either > > a) releasing individual pages within a range (and thus likely messing > up their count of pages they have), or > > b) allocating two gup ranges within the same pages[] array, with a > gap between the allocations, > > ...then it should be correct. If so, then I'll add the above blurb > to this patch's commit description. > > If that's not the case (both here, and in 3 or 4 other patches in this > series, then as you said, I should add NULL checks to put_user_pages() > and put_user_pages_dirty_lock(). In this case it is not correct, but can easily be handled. The NULL case can occur only in an error case with the pages array filled partially or not at all. I'd prefer something like the attached patch here. Juergen
> > On 02.08.19 07:48, John Hubbard wrote: > > On 8/1/19 9:36 PM, Juergen Gross wrote: > >> On 02.08.19 04:19, john.hubbard@gmail.com wrote: > >>> From: John Hubbard <jhubbard@nvidia.com> > > ... > >>> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index > >>> 2f5ce7230a43..29e461dbee2d 100644 > >>> --- a/drivers/xen/privcmd.c > >>> +++ b/drivers/xen/privcmd.c > >>> @@ -611,15 +611,10 @@ static int lock_pages( > >>> static void unlock_pages(struct page *pages[], unsigned int > >>> nr_pages) > >>> { > >>> - unsigned int i; > >>> - > >>> if (!pages) > >>> return; > >>> - for (i = 0; i < nr_pages; i++) { > >>> - if (pages[i]) > >>> - put_page(pages[i]); > >>> - } > >>> + put_user_pages(pages, nr_pages); > >> > >> You are not handling the case where pages[i] is NULL here. Or am I > >> missing a pending patch to put_user_pages() here? > >> > > > > Hi Juergen, > > > > You are correct--this no longer handles the cases where pages[i] is > > NULL. It's intentional, though possibly wrong. :) > > > > I see that I should have added my standard blurb to this commit > > description. I missed this one, but some of the other patches have it. > > It makes the following, possibly incorrect claim: > > > > "This changes the release code slightly, because each page slot in the > > page_list[] array is no longer checked for NULL. However, that check > > was wrong anyway, because the get_user_pages() pattern of usage here > > never allowed for NULL entries within a range of pinned pages." > > > > The way I've seen these page arrays used with get_user_pages(), things > > are either done single page, or with a contiguous range. So unless I'm > > missing a case where someone is either > > > > a) releasing individual pages within a range (and thus likely messing > > up their count of pages they have), or > > > > b) allocating two gup ranges within the same pages[] array, with a gap > > between the allocations, > > > > ...then it should be correct. If so, then I'll add the above blurb to > > this patch's commit description. > > > > If that's not the case (both here, and in 3 or 4 other patches in this > > series, then as you said, I should add NULL checks to put_user_pages() > > and put_user_pages_dirty_lock(). > > In this case it is not correct, but can easily be handled. The NULL case can > occur only in an error case with the pages array filled partially or not at all. > > I'd prefer something like the attached patch here. I'm not an expert in this code and have not looked at it carefully but that patch does seem to be the better fix than forcing NULL checks on everyone. Ira
On 8/2/19 9:09 AM, Weiny, Ira wrote: >> >> On 02.08.19 07:48, John Hubbard wrote: >>> On 8/1/19 9:36 PM, Juergen Gross wrote: >>>> On 02.08.19 04:19, john.hubbard@gmail.com wrote: >>>>> From: John Hubbard <jhubbard@nvidia.com> >>> ... >>> If that's not the case (both here, and in 3 or 4 other patches in this >>> series, then as you said, I should add NULL checks to put_user_pages() >>> and put_user_pages_dirty_lock(). >> >> In this case it is not correct, but can easily be handled. The NULL case can >> occur only in an error case with the pages array filled partially or not at all. >> >> I'd prefer something like the attached patch here. > > I'm not an expert in this code and have not looked at it carefully but that patch does seem to be the better fix than forcing NULL checks on everyone. > OK, I'll use Juergen's approach, and also check for that pattern in the other patches. thanks,
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 4c339c7e66e5..2586b3df2bb6 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -864,10 +864,7 @@ static int gntdev_get_page(struct gntdev_copy_batch *batch, void __user *virt, static void gntdev_put_pages(struct gntdev_copy_batch *batch) { - unsigned int i; - - for (i = 0; i < batch->nr_pages; i++) - put_page(batch->pages[i]); + put_user_pages(batch->pages, batch->nr_pages); batch->nr_pages = 0; } diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 2f5ce7230a43..29e461dbee2d 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -611,15 +611,10 @@ static int lock_pages( static void unlock_pages(struct page *pages[], unsigned int nr_pages) { - unsigned int i; - if (!pages) return; - for (i = 0; i < nr_pages; i++) { - if (pages[i]) - put_page(pages[i]); - } + put_user_pages(pages, nr_pages); } static long privcmd_ioctl_dm_op(struct file *file, void __user *udata)