| Message ID | 20190802194702.30249-2-stefan-gabriel.mirea@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add initial support for S32V234-EVB | expand |
On Fri, Aug 2, 2019 at 1:47 PM Stefan-gabriel Mirea <stefan-gabriel.mirea@nxp.com> wrote: > > From: Eddy Petrișor <eddy.petrisor@nxp.com> > > Add entry for the NXP S32V234 Customer Evaluation Board to the board/SoC > bindings. > > Signed-off-by: Eddy Petrișor <eddy.petrisor@nxp.com> > Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 7294ac36f4c0..104d60a11177 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -309,4 +309,10 @@ properties: > - fsl,ls2088a-rdb > - const: fsl,ls2088a > > + - description: S32V234 Customer Evaluation Board Most of the entries in this file are for all the boards for an SoC. > + items: > + - enum: > + - fsl,s32v234-evb If that's not going to be the case here, you can use 'const' here. > + - const: fsl,s32v234 > + > ... > -- > 2.22.0 >
Hello Rob, On 8/3/2019 1:38 AM, Rob Herring wrote: > On Fri, Aug 2, 2019 at 1:47 PM Stefan-gabriel Mirea > <stefan-gabriel.mirea@nxp.com> wrote: >> + - description: S32V234 Customer Evaluation Board > > Most of the entries in this file are for all the boards for an SoC. > >> + items: >> + - enum: >> + - fsl,s32v234-evb > > If that's not going to be the case here, you can use 'const' here. We also intend to submit patches for the SBC-S32V234[1] board in the future and I believe that its 'compatible' should share this entry. Would it therefore be preferable to update the description at this moment and add a comment, like: - description: S32V234 based Boards items: - enum: - fsl,s32v234-evb # S32V234-EVB2 Customer Evaluation Board - const: fsl,s32v234 or just replace the single-value 'enum' with a 'const' for now? Regards, Stefan [1] https://www.nxp.com/design/development-boards/automotive-development-platforms/s32v-mpus-platforms/s32v-vision-and-sensor-fusion-evaluation-board:SBC-S32V234
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 7294ac36f4c0..104d60a11177 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -309,4 +309,10 @@ properties: - fsl,ls2088a-rdb - const: fsl,ls2088a + - description: S32V234 Customer Evaluation Board + items: + - enum: + - fsl,s32v234-evb + - const: fsl,s32v234 + ...