| Message ID | 20190803082517.15035-1-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, 3 Aug 2019 at 09:26, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > The following changes since commit 9bcf2dfa163f67b0fec6ee0fe88ad5dc5d69dc59: > > Merge remote-tracking branch 'remotes/elmarco/tags/slirp-CVE-2019-14378-pull-request' into staging (2019-08-02 13:06:03 +0100) > > are available in the Git repository at: > > https://gitlab.com/philmd/qemu.git tags/edk2-next-20190803 > > for you to fetch changes up to 177cd674d6203d3c1a98e170ea56c5a904ac4ce8: > > Makefile: remove DESTDIR from firmware file content (2019-08-03 09:52:32 +0200) > > ---------------------------------------------------------------- > A harmless build-sys patch that fixes a regression affecting Linux > distributions packaging QEMU. > > ---------------------------------------------------------------- > > Olaf Hering (1): > Makefile: remove DESTDIR from firmware file content Is this pullreq intended for 4.1 ? thanks -- PMM
On 8/3/19 12:22 PM, Peter Maydell wrote: > On Sat, 3 Aug 2019 at 09:26, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >> >> The following changes since commit 9bcf2dfa163f67b0fec6ee0fe88ad5dc5d69dc59: >> >> Merge remote-tracking branch 'remotes/elmarco/tags/slirp-CVE-2019-14378-pull-request' into staging (2019-08-02 13:06:03 +0100) >> >> are available in the Git repository at: >> >> https://gitlab.com/philmd/qemu.git tags/edk2-next-20190803 >> >> for you to fetch changes up to 177cd674d6203d3c1a98e170ea56c5a904ac4ce8: >> >> Makefile: remove DESTDIR from firmware file content (2019-08-03 09:52:32 +0200) >> >> ---------------------------------------------------------------- >> A harmless build-sys patch that fixes a regression affecting Linux >> distributions packaging QEMU. >> >> ---------------------------------------------------------------- >> >> Olaf Hering (1): >> Makefile: remove DESTDIR from firmware file content > > Is this pullreq intended for 4.1 ? Please do pull it into 4.1 as the commit it fixes is aiming at 4.1 (just like the whole feature). If not included then distros will need to backport it anyway. Just my $0.02. Let's wait for Philippe's confirmation. Michal
Hi Peter, On 8/5/19 3:13 PM, Michal Prívozník wrote: > On 8/3/19 12:22 PM, Peter Maydell wrote: >> On Sat, 3 Aug 2019 at 09:26, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >>> >>> The following changes since commit 9bcf2dfa163f67b0fec6ee0fe88ad5dc5d69dc59: >>> >>> Merge remote-tracking branch 'remotes/elmarco/tags/slirp-CVE-2019-14378-pull-request' into staging (2019-08-02 13:06:03 +0100) >>> >>> are available in the Git repository at: >>> >>> https://gitlab.com/philmd/qemu.git tags/edk2-next-20190803 >>> >>> for you to fetch changes up to 177cd674d6203d3c1a98e170ea56c5a904ac4ce8: >>> >>> Makefile: remove DESTDIR from firmware file content (2019-08-03 09:52:32 +0200) >>> >>> ---------------------------------------------------------------- >>> A harmless build-sys patch that fixes a regression affecting Linux >>> distributions packaging QEMU. >>> >>> ---------------------------------------------------------------- >>> >>> Olaf Hering (1): >>> Makefile: remove DESTDIR from firmware file content >> >> Is this pullreq intended for 4.1 ? Sorry, I was not sure how to comment on the pullreq cover (everything between the '---' lines get include in the merge commit description). This fix a regression introduced during the current development cycle. Already 3 different distributions hit this issue and complained (Suse, ArchLinux and Fedora). This is not a critical/security issue and distributions can easily backport this patch, but since there is a RC4 planned, it would be nice regarding distributors to fix this if possible. > Please do pull it into 4.1 as the commit it fixes is aiming at 4.1 (just > like the whole feature). If not included then distros will need to > backport it anyway. Just my $0.02. Let's wait for Philippe's confirmation. Exactly. Thanks, Phil.
On Mon, 5 Aug 2019 at 15:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Hi Peter, > > On 8/5/19 3:13 PM, Michal Prívozník wrote: > > On 8/3/19 12:22 PM, Peter Maydell wrote: > >> On Sat, 3 Aug 2019 at 09:26, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > >>> > >>> The following changes since commit 9bcf2dfa163f67b0fec6ee0fe88ad5dc5d69dc59: > >>> > >>> Merge remote-tracking branch 'remotes/elmarco/tags/slirp-CVE-2019-14378-pull-request' into staging (2019-08-02 13:06:03 +0100) > >>> > >>> are available in the Git repository at: > >>> > >>> https://gitlab.com/philmd/qemu.git tags/edk2-next-20190803 > >>> > >>> for you to fetch changes up to 177cd674d6203d3c1a98e170ea56c5a904ac4ce8: > >>> > >>> Makefile: remove DESTDIR from firmware file content (2019-08-03 09:52:32 +0200) > >>> > >>> ---------------------------------------------------------------- > >>> A harmless build-sys patch that fixes a regression affecting Linux > >>> distributions packaging QEMU. > >>> > >>> ---------------------------------------------------------------- > >>> > >>> Olaf Hering (1): > >>> Makefile: remove DESTDIR from firmware file content > >> > >> Is this pullreq intended for 4.1 ? > > Sorry, I was not sure how to comment on the pullreq cover (everything > between the '---' lines get include in the merge commit description). Depends on your workflow. For me my pull-request-creation script creates a bunch of files which will be the emails to be sent out, and I can manually edit the 'cover letter' email before sending everything. > This fix a regression introduced during the current development cycle. > Already 3 different distributions hit this issue and complained (Suse, > ArchLinux and Fedora). > This is not a critical/security issue and distributions can easily > backport this patch, but since there is a RC4 planned, it would be nice > regarding distributors to fix this if possible. OK, sounds good -- I just wanted to check. I've pushed the pullreq to master. thanks -- PMM
On 8/5/19 4:14 PM, Peter Maydell wrote: > On Mon, 5 Aug 2019 at 15:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >> >> Hi Peter, >> >> On 8/5/19 3:13 PM, Michal Prívozník wrote: >>> On 8/3/19 12:22 PM, Peter Maydell wrote: >>>> On Sat, 3 Aug 2019 at 09:26, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >>>>> >>>>> The following changes since commit 9bcf2dfa163f67b0fec6ee0fe88ad5dc5d69dc59: >>>>> >>>>> Merge remote-tracking branch 'remotes/elmarco/tags/slirp-CVE-2019-14378-pull-request' into staging (2019-08-02 13:06:03 +0100) >>>>> >>>>> are available in the Git repository at: >>>>> >>>>> https://gitlab.com/philmd/qemu.git tags/edk2-next-20190803 >>>>> >>>>> for you to fetch changes up to 177cd674d6203d3c1a98e170ea56c5a904ac4ce8: >>>>> >>>>> Makefile: remove DESTDIR from firmware file content (2019-08-03 09:52:32 +0200) >>>>> >>>>> ---------------------------------------------------------------- >>>>> A harmless build-sys patch that fixes a regression affecting Linux >>>>> distributions packaging QEMU. >>>>> >>>>> ---------------------------------------------------------------- >>>>> >>>>> Olaf Hering (1): >>>>> Makefile: remove DESTDIR from firmware file content >>>> >>>> Is this pullreq intended for 4.1 ? >> >> Sorry, I was not sure how to comment on the pullreq cover (everything >> between the '---' lines get include in the merge commit description). > > Depends on your workflow. For me my pull-request-creation > script creates a bunch of files which will be the emails > to be sent out, and I can manually edit the 'cover letter' > email before sending everything. OK (I don't want to give you extra manual work). >> This fix a regression introduced during the current development cycle. >> Already 3 different distributions hit this issue and complained (Suse, >> ArchLinux and Fedora). >> This is not a critical/security issue and distributions can easily >> backport this patch, but since there is a RC4 planned, it would be nice >> regarding distributors to fix this if possible. > > OK, sounds good -- I just wanted to check. I've pushed the > pullreq to master. Thank you!
On 08/05/19 16:29, Philippe Mathieu-Daudé wrote: > On 8/5/19 4:14 PM, Peter Maydell wrote: >> On Mon, 5 Aug 2019 at 15:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >>> >>> Hi Peter, >>> >>> On 8/5/19 3:13 PM, Michal Prívozník wrote: >>>> On 8/3/19 12:22 PM, Peter Maydell wrote: >>>>> On Sat, 3 Aug 2019 at 09:26, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >>>>>> >>>>>> The following changes since commit 9bcf2dfa163f67b0fec6ee0fe88ad5dc5d69dc59: >>>>>> >>>>>> Merge remote-tracking branch 'remotes/elmarco/tags/slirp-CVE-2019-14378-pull-request' into staging (2019-08-02 13:06:03 +0100) >>>>>> >>>>>> are available in the Git repository at: >>>>>> >>>>>> https://gitlab.com/philmd/qemu.git tags/edk2-next-20190803 >>>>>> >>>>>> for you to fetch changes up to 177cd674d6203d3c1a98e170ea56c5a904ac4ce8: >>>>>> >>>>>> Makefile: remove DESTDIR from firmware file content (2019-08-03 09:52:32 +0200) >>>>>> >>>>>> ---------------------------------------------------------------- >>>>>> A harmless build-sys patch that fixes a regression affecting Linux >>>>>> distributions packaging QEMU. >>>>>> >>>>>> ---------------------------------------------------------------- >>>>>> >>>>>> Olaf Hering (1): >>>>>> Makefile: remove DESTDIR from firmware file content >>>>> >>>>> Is this pullreq intended for 4.1 ? >>> >>> Sorry, I was not sure how to comment on the pullreq cover (everything >>> between the '---' lines get include in the merge commit description). >> >> Depends on your workflow. For me my pull-request-creation >> script creates a bunch of files which will be the emails >> to be sent out, and I can manually edit the 'cover letter' >> email before sending everything. > > OK (I don't want to give you extra manual work). > >>> This fix a regression introduced during the current development cycle. >>> Already 3 different distributions hit this issue and complained (Suse, >>> ArchLinux and Fedora). >>> This is not a critical/security issue and distributions can easily >>> backport this patch, but since there is a RC4 planned, it would be nice >>> regarding distributors to fix this if possible. >> >> OK, sounds good -- I just wanted to check. I've pushed the >> pullreq to master. > > Thank you! > Thank you all, I've updated <https://bugs.launchpad.net/qemu/+bug/1838703>. Laszlo