| Message ID | 20190805162710.7789-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 5c7f48dd14e892e3e920dd6bbbd52df79e1b3b41 |
| Headers | show |
| Series | [1/4] pinctrl: samsung: Fix device node refcount leaks in Exynos wakeup controller init | expand |
On Mon, Aug 5, 2019 at 6:27 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > In exynos_eint_wkup_init() the for_each_child_of_node() loop is used > with a break to find a matching child node. Although each iteration of > for_each_child_of_node puts the previous node, but early exit from loop > misses it. This leads to leak of device node. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> I assume you're collecting these for a pull request to me at some later point, all look good to me. Yours, Linus Walleij
On Tue, 6 Aug 2019 at 16:15, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Mon, Aug 5, 2019 at 6:27 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > In exynos_eint_wkup_init() the for_each_child_of_node() loop is used > > with a break to find a matching child node. Although each iteration of > > for_each_child_of_node puts the previous node, but early exit from loop > > misses it. This leads to leak of device node. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > I assume you're collecting these for a pull request to me > at some later point, all look good to me. Yes, I'll take these and one more patch from lists and send them to you. Best regards, Krzysztof
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index ebc27b06718c..8d2c33bba13e 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -504,6 +504,7 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d) bank->nr_pins, &exynos_eint_irqd_ops, bank); if (!bank->irq_domain) { dev_err(dev, "wkup irq domain add failed\n"); + of_node_put(wkup_np); return -ENXIO; } @@ -518,8 +519,10 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d) weint_data = devm_kcalloc(dev, bank->nr_pins, sizeof(*weint_data), GFP_KERNEL); - if (!weint_data) + if (!weint_data) { + of_node_put(wkup_np); return -ENOMEM; + } for (idx = 0; idx < bank->nr_pins; ++idx) { irq = irq_of_parse_and_map(bank->of_node, idx); @@ -536,10 +539,13 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d) } } - if (!muxed_banks) + if (!muxed_banks) { + of_node_put(wkup_np); return 0; + } irq = irq_of_parse_and_map(wkup_np, 0); + of_node_put(wkup_np); if (!irq) { dev_err(dev, "irq number for muxed EINTs not found\n"); return 0;
In exynos_eint_wkup_init() the for_each_child_of_node() loop is used with a break to find a matching child node. Although each iteration of for_each_child_of_node puts the previous node, but early exit from loop misses it. This leads to leak of device node. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/pinctrl/samsung/pinctrl-exynos.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)