diff mbox series

[01/28] ASoC: soc-core: use device_register()

Message ID	87zhkn2iin.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <alsa-devel-bounces@alsa-project.org> Date: 06 Aug 2019 10:27:57 +0900 Message-ID: <87zhkn2iin.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 To: Mark Brown <broonie@kernel.org> In-Reply-To: <871rxz3x7e.wl-kuninori.morimoto.gx@renesas.com> References: <871rxz3x7e.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Linux-ALSA <alsa-devel@alsa-project.org> Subject: [alsa-devel] [PATCH 01/28] ASoC: soc-core: use device_register() Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" <alsa-devel-bounces@alsa-project.org>
Series	ASoC: cleanup patches for soc-core \| expand [00/28] ASoC: cleanup patches for soc-core [01/28] ASoC: soc-core: use device_register() [02/28] ASoC: soc-core: set component->debugfs_root NULL [03/28] ASoC: soc-core: add comment for for_each_xxx [04/28] ASoC: soc-core: check return value of snd_soc_add_dai_link() [05/28] ASoC: soc-core: don't use for_each_card_links_safe() at snd_soc_find_dai_link() [06/28] ASoC: soc-core: reuse rtdcom at snd_soc_rtdcom_add() [07/28] ASoC: soc-core: don't check widget for snd_soc_dapm_new_controls() [08/28] ASoC: soc-core: don't check controls for snd_soc_add_component_controls() [09/28] ASoC: soc-core: don't check routes for snd_soc_dapm_add_routes() [10/28] ASoC: soc-core: don't check controls for snd_soc_add_card_controls() [11/28] ASoC: soc-core: call snd_soc_dapm_debugfs_init() at soc_init_card_debugfs() [12/28] ASoC: soc-core: remove unneeded list_empty() check for snd_soc_try_rebind_card() [13/28] ASoC: soc-core: remove verbose debug message from soc_bind_dai_link() [14/28] ASoC: soc-core: remove duplicated soc_is_dai_link_bound() [15/28] ASoC: soc-core: tidyup for card->deferred_resume_work [16/28] ASoC: soc-core: initialize rtd->list [17/28] ASoC: soc-core: define soc_dpcm_debugfs_add() for non CONFIG_DEBUG_FS [18/28] ASoC: soc-core: dai_link check under soc_dpcm_debugfs_add() [19/28] ASoC: soc-core: merge snd_soc_initialize_card_lists() [20/28] ASoC: soc-core: remove unneeded dai_link check from snd_soc_remove_dai_link() [21/28] ASoC: soc-core: add NOTE to snd_soc_rtdcom_lookup() [22/28] ASoC: soc-core: don't call snd_soc_component_set_jack() [23/28] ASoC: soc-core: don't alloc memory carelessly when creating debugfs [24/28] ASoC: soc-core: soc_cleanup_card_resources() become void [25/28] ASoC: soc-core: initialize component list [26/28] ASoC: soc-core: initialize list at one place [27/28] ASoC: soc-dai: use bit field for bus_control [28/28] ASoC: soc-topology: use for_each_component_dais() at remove_dai()

Commit Message

Kuninori Morimoto Aug. 6, 2019, 1:27 a.m. UTC

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

It is easy to read code if it is cleanly using paired function/naming,
like start <-> stop, register <-> unregister, etc, etc.
But, current ALSA SoC code is very random, unbalance, not paired, etc.

soc-core.c is using device_unregiser(), but there is no its paired
device_regiser(). We can find its code at soc_post_component_init()
which is using device_initialize() and device_add().
Here, device_initialize() + device_add() = device_register().

device_initialize() is doing each dev member's initialization only.
So, the timing is not important here.
let's use device_register() instead of device_initialize()/device_add().

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/soc-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 0f75dac..40bac40 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1336,7 +1336,6 @@  static int soc_post_component_init(struct snd_soc_pcm_runtime *rtd,
 	rtd->dev = kzalloc(sizeof(struct device), GFP_KERNEL);
 	if (!rtd->dev)
 		return -ENOMEM;
-	device_initialize(rtd->dev);
 	rtd->dev->parent = rtd->card->dev;
 	rtd->dev->release = rtd_release;
 	rtd->dev->groups = soc_dev_attr_groups;
@@ -1347,7 +1346,7 @@  static int soc_post_component_init(struct snd_soc_pcm_runtime *rtd,
 	INIT_LIST_HEAD(&rtd->dpcm[SNDRV_PCM_STREAM_CAPTURE].be_clients);
 	INIT_LIST_HEAD(&rtd->dpcm[SNDRV_PCM_STREAM_PLAYBACK].fe_clients);
 	INIT_LIST_HEAD(&rtd->dpcm[SNDRV_PCM_STREAM_CAPTURE].fe_clients);
-	ret = device_add(rtd->dev);
+	ret = device_register(rtd->dev);
 	if (ret < 0) {
 		/* calling put_device() here to free the rtd->dev */
 		put_device(rtd->dev);