| Message ID | 20190806125041.16105-2-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: net: meson-dwmac: convert to yaml | expand |
+Maxime On Tue, Aug 6, 2019 at 6:50 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > The Amlogic Meson DWMAC glue bindings needs a second reg cells for the > glue registers, thus update the reg minItems/maxItems to allow more > than a single reg cell. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I haven't checked, but the derivative schema could be assuming this schema enforced reg is 1 item. I don't think that's a major issue though. Acked-by: Rob Herring <robh@kernel.org>
Hi, On Tue, Aug 06, 2019 at 09:22:12AM -0600, Rob Herring wrote: > +Maxime > > On Tue, Aug 6, 2019 at 6:50 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > > > The Amlogic Meson DWMAC glue bindings needs a second reg cells for the > > glue registers, thus update the reg minItems/maxItems to allow more > > than a single reg cell. > > > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > > --- > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > I haven't checked, but the derivative schema could be assuming this > schema enforced reg is 1 item. Yeah, we do for Documentation/devicetree/bindings/net/allwinner,sun7i-a20-gmac.yaml (but somehow not allwinner,sun8i-a83t-emac.yaml) Neil, can you add it to sun7i-a20-gmac? > I don't think that's a major issue > though. > > Acked-by: Rob Herring <robh@kernel.org> With that fixed, Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 76fea2be66ac..4377f511a51d 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -61,7 +61,8 @@ properties: - snps,dwxgmac-2.10 reg: - maxItems: 1 + minItems: 1 + maxItems: 2 interrupts: minItems: 1
The Amlogic Meson DWMAC glue bindings needs a second reg cells for the glue registers, thus update the reg minItems/maxItems to allow more than a single reg cell. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)