[v1,16/18] xprtdma: Fix bc_max_slots return value
diff mbox series

Message ID 20190806155511.9529.93076.stgit@manet.1015granger.net
State New
Headers show
  • NFS/RDMA patches
Related show

Commit Message

Chuck Lever Aug. 6, 2019, 3:55 p.m. UTC
For the moment the returned value just happens to be correct because
the current backchannel server implementation does not vary the
number of credits it offers. The spec does permit this value to
change during the lifetime of a connection, however.

The actual maximum is fixed for all RPC/RDMA transports, because
each transport instance has to pre-allocate the resources for
processing BC requests. That's the value that should be returned.

Fixes: 7402a4fedc2b ("SUNRPC: Fix up backchannel slot table ... ")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
 net/sunrpc/xprtrdma/backchannel.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff mbox series

diff --git a/net/sunrpc/xprtrdma/backchannel.c b/net/sunrpc/xprtrdma/backchannel.c
index 59e624b..50e075f 100644
--- a/net/sunrpc/xprtrdma/backchannel.c
+++ b/net/sunrpc/xprtrdma/backchannel.c
@@ -54,9 +54,7 @@  size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *xprt)
 unsigned int xprt_rdma_bc_max_slots(struct rpc_xprt *xprt)
-	struct rpcrdma_xprt *r_xprt = rpcx_to_rdmax(xprt);
-	return r_xprt->rx_buf.rb_bc_srv_max_requests;
 static int rpcrdma_bc_marshal_reply(struct rpc_rqst *rqst)