| Message ID | 20190807004828.28059-1-balsini@android.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] loop: Add LOOP_SET_DIRECT_IO to compat ioctl | expand |
On Wed, Aug 07, 2019 at 01:48:28AM +0100, Alessio Balsini wrote: > Enabling Direct I/O with loop devices helps reducing memory usage by > avoiding double caching. 32 bit applications running on 64 bits systems > are currently not able to request direct I/O because is missing from the > lo_compat_ioctl. > > This patch fixes the compatibility issue mentioned above by exporting > LOOP_SET_DIRECT_IO as additional lo_compat_ioctl() entry. > The input argument for this ioctl is a single long converted to a 1-bit > boolean, so compatibility is preserved. This commit message looks better now. thanks, - Joel > Cc: Jens Axboe <axboe@kernel.dk> > Signed-off-by: Alessio Balsini <balsini@android.com> > --- > drivers/block/loop.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 44c9985f352ab..2e2193f754ab0 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -1753,6 +1753,7 @@ static int lo_compat_ioctl(struct block_device *bdev, fmode_t mode, > case LOOP_SET_FD: > case LOOP_CHANGE_FD: > case LOOP_SET_BLOCK_SIZE: > + case LOOP_SET_DIRECT_IO: > err = lo_ioctl(bdev, mode, cmd, arg); > break; > default: > -- > 2.23.0.rc1.153.gdeed80330f-goog >
On 8/6/19 5:48 PM, Alessio Balsini wrote: > Enabling Direct I/O with loop devices helps reducing memory usage by > avoiding double caching. 32 bit applications running on 64 bits systems > are currently not able to request direct I/O because is missing from the > lo_compat_ioctl. > > This patch fixes the compatibility issue mentioned above by exporting > LOOP_SET_DIRECT_IO as additional lo_compat_ioctl() entry. > The input argument for this ioctl is a single long converted to a 1-bit > boolean, so compatibility is preserved. Applied, thanks.
diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 44c9985f352ab..2e2193f754ab0 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1753,6 +1753,7 @@ static int lo_compat_ioctl(struct block_device *bdev, fmode_t mode, case LOOP_SET_FD: case LOOP_CHANGE_FD: case LOOP_SET_BLOCK_SIZE: + case LOOP_SET_DIRECT_IO: err = lo_ioctl(bdev, mode, cmd, arg); break; default:
Enabling Direct I/O with loop devices helps reducing memory usage by avoiding double caching. 32 bit applications running on 64 bits systems are currently not able to request direct I/O because is missing from the lo_compat_ioctl. This patch fixes the compatibility issue mentioned above by exporting LOOP_SET_DIRECT_IO as additional lo_compat_ioctl() entry. The input argument for this ioctl is a single long converted to a 1-bit boolean, so compatibility is preserved. Cc: Jens Axboe <axboe@kernel.dk> Signed-off-by: Alessio Balsini <balsini@android.com> --- drivers/block/loop.c | 1 + 1 file changed, 1 insertion(+)