| Message ID | 20190807082556.5013-20-philippe.schenker@toradex.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Common patches from downstream development | expand |
Hi Philippe On Wed, 2019-08-07 at 08:26 +0000, Philippe Schenker wrote: > In order for the otg ports, that these modules support, it is needed > that dr_mode is on otg. Switch to use that feature. Isn't further extcon integration required for this to truly work? > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > --- > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +- > arch/arm/boot/dts/imx7-colibri.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi > b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > index 9a63debab0b5..6674198346d2 100644 > --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > @@ -388,7 +388,7 @@ > &usbotg { > pinctrl-names = "default"; > disable-over-current; > - dr_mode = "peripheral"; > + dr_mode = "otg"; > status = "disabled"; > }; > > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi > b/arch/arm/boot/dts/imx7-colibri.dtsi > index 67f5e0c87fdc..42478f1aa146 100644 > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > @@ -320,7 +320,7 @@ > }; > > &usbotg1 { > - dr_mode = "host"; > + dr_mode = "otg"; > }; > > &usdhc1 { Cheers Marcel
On Fri, 2019-08-09 at 15:50 +0000, Marcel Ziswiler wrote: > Hi Philippe > > On Wed, 2019-08-07 at 08:26 +0000, Philippe Schenker wrote: > > In order for the otg ports, that these modules support, it is needed > > that dr_mode is on otg. Switch to use that feature. > > Isn't further extcon integration required for this to truly work? Yes, I wasn't aware of that. I will drop this patch as this is a whole new topic and will hopefully be a whole new patchset soon. Philippe > > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > > --- > > > > Changes in v3: None > > Changes in v2: None > > > > arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +- > > arch/arm/boot/dts/imx7-colibri.dtsi | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi > > b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > > index 9a63debab0b5..6674198346d2 100644 > > --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > > @@ -388,7 +388,7 @@ > > &usbotg { > > pinctrl-names = "default"; > > disable-over-current; > > - dr_mode = "peripheral"; > > + dr_mode = "otg"; > > status = "disabled"; > > }; > > > > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi > > b/arch/arm/boot/dts/imx7-colibri.dtsi > > index 67f5e0c87fdc..42478f1aa146 100644 > > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > > @@ -320,7 +320,7 @@ > > }; > > > > &usbotg1 { > > - dr_mode = "host"; > > + dr_mode = "otg"; > > }; > > > > &usdhc1 { > > Cheers > > Marcel
diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi index 9a63debab0b5..6674198346d2 100644 --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi @@ -388,7 +388,7 @@ &usbotg { pinctrl-names = "default"; disable-over-current; - dr_mode = "peripheral"; + dr_mode = "otg"; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi index 67f5e0c87fdc..42478f1aa146 100644 --- a/arch/arm/boot/dts/imx7-colibri.dtsi +++ b/arch/arm/boot/dts/imx7-colibri.dtsi @@ -320,7 +320,7 @@ }; &usbotg1 { - dr_mode = "host"; + dr_mode = "otg"; }; &usdhc1 {
In order for the otg ports, that these modules support, it is needed that dr_mode is on otg. Switch to use that feature. Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> --- Changes in v3: None Changes in v2: None arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +- arch/arm/boot/dts/imx7-colibri.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)