[v3,1/3] clocksource/drivers/renesas-ostm: Use DIV_ROUND_CLOSEST() helper
diff mbox series

Message ID 20190807084635.24173-2-geert+renesas@glider.be
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series
  • clocksource/drivers/ostm: Miscellaneous improvements
Related show

Commit Message

Geert Uytterhoeven Aug. 7, 2019, 8:46 a.m. UTC
Use the DIV_ROUND_CLOSEST() helper instead of open-coding the same
operation.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v3:
  - New.
---
 drivers/clocksource/renesas-ostm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman Aug. 16, 2019, 12:58 p.m. UTC | #1
On Wed, Aug 07, 2019 at 10:46:33AM +0200, Geert Uytterhoeven wrote:
> Use the DIV_ROUND_CLOSEST() helper instead of open-coding the same
> operation.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
> v3:
>   - New.
> ---
>  drivers/clocksource/renesas-ostm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/renesas-ostm.c b/drivers/clocksource/renesas-ostm.c
> index 61d5f3b539ce23df..37c39b901bb12b38 100644
> --- a/drivers/clocksource/renesas-ostm.c
> +++ b/drivers/clocksource/renesas-ostm.c
> @@ -221,7 +221,7 @@ static int __init ostm_init(struct device_node *np)
>  	}
>  
>  	rate = clk_get_rate(ostm_clk);
> -	ostm->ticks_per_jiffy = (rate + HZ / 2) / HZ;
> +	ostm->ticks_per_jiffy = DIV_ROUND_CLOSEST(rate, HZ);
>  
>  	/*
>  	 * First probed device will be used as system clocksource. Any
> -- 
> 2.17.1
>
Daniel Lezcano Aug. 16, 2019, 1 p.m. UTC | #2
On 16/08/2019 14:58, Simon Horman wrote:
> On Wed, Aug 07, 2019 at 10:46:33AM +0200, Geert Uytterhoeven wrote:
>> Use the DIV_ROUND_CLOSEST() helper instead of open-coding the same
>> operation.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Applied this one, thanks

I'm waiting Geert feedbacks for 2/3 and 3/3.

Patch
diff mbox series

diff --git a/drivers/clocksource/renesas-ostm.c b/drivers/clocksource/renesas-ostm.c
index 61d5f3b539ce23df..37c39b901bb12b38 100644
--- a/drivers/clocksource/renesas-ostm.c
+++ b/drivers/clocksource/renesas-ostm.c
@@ -221,7 +221,7 @@  static int __init ostm_init(struct device_node *np)
 	}
 
 	rate = clk_get_rate(ostm_clk);
-	ostm->ticks_per_jiffy = (rate + HZ / 2) / HZ;
+	ostm->ticks_per_jiffy = DIV_ROUND_CLOSEST(rate, HZ);
 
 	/*
 	 * First probed device will be used as system clocksource. Any