crypto: chtls - use 'skb_put_zero()' instead of re-implementing it
diff mbox series

Message ID 20190807154014.22548-1-christophe.jaillet@wanadoo.fr
State Rejected
Delegated to: Herbert Xu
Headers show
Series
  • crypto: chtls - use 'skb_put_zero()' instead of re-implementing it
Related show

Commit Message

Christophe JAILLET Aug. 7, 2019, 3:40 p.m. UTC
'skb_put()+memset()' is equivalent to 'skb_put_zero()'
Use the latter because it is less verbose and it hides the internals of the
sk_buff structure.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/crypto/chelsio/chtls/chtls_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Herbert Xu Aug. 15, 2019, 5 a.m. UTC | #1
On Wed, Aug 07, 2019 at 05:40:14PM +0200, Christophe JAILLET wrote:
> 'skb_put()+memset()' is equivalent to 'skb_put_zero()'
> Use the latter because it is less verbose and it hides the internals of the
> sk_buff structure.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/crypto/chelsio/chtls/chtls_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c b/drivers/crypto/chelsio/chtls/chtls_main.c
> index 635bb4b447fb..830b238da77e 100644
> --- a/drivers/crypto/chelsio/chtls/chtls_main.c
> +++ b/drivers/crypto/chelsio/chtls/chtls_main.c
> @@ -218,9 +218,8 @@ static int chtls_get_skb(struct chtls_dev *cdev)
>  	if (!cdev->askb)
>  		return -ENOMEM;
>  
> -	skb_put(cdev->askb, sizeof(struct tcphdr));
> +	skb_put_zero(cdev->askb, sizeof(struct tcphdr));
>  	skb_reset_transport_header(cdev->askb);
> -	memset(cdev->askb->data, 0, cdev->askb->len);

These two are NOT equivalent.

Patch
diff mbox series

diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c b/drivers/crypto/chelsio/chtls/chtls_main.c
index 635bb4b447fb..830b238da77e 100644
--- a/drivers/crypto/chelsio/chtls/chtls_main.c
+++ b/drivers/crypto/chelsio/chtls/chtls_main.c
@@ -218,9 +218,8 @@  static int chtls_get_skb(struct chtls_dev *cdev)
 	if (!cdev->askb)
 		return -ENOMEM;
 
-	skb_put(cdev->askb, sizeof(struct tcphdr));
+	skb_put_zero(cdev->askb, sizeof(struct tcphdr));
 	skb_reset_transport_header(cdev->askb);
-	memset(cdev->askb->data, 0, cdev->askb->len);
 	return 0;
 }