scsi: lpfc: remove redundant code
diff mbox series

Message ID 20190808013525.13681-1-huangfq.daxian@gmail.com
State Accepted
Headers show
Series
  • scsi: lpfc: remove redundant code
Related show

Commit Message

Fuqian Huang Aug. 8, 2019, 1:35 a.m. UTC
Remove the redundant initialization code.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
 drivers/scsi/lpfc/lpfc_bsg.c | 1 -
 drivers/scsi/lpfc/lpfc_sli.c | 1 -
 2 files changed, 2 deletions(-)

Comments

James Smart Aug. 16, 2019, 7:56 p.m. UTC | #1
On 8/7/2019 6:35 PM, Fuqian Huang wrote:
> Remove the redundant initialization code.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
>

Looks good!

Reviewed-by: James Smart <james.smart@broadcom.com>

-- james
Martin K. Petersen Aug. 20, 2019, 2:08 a.m. UTC | #2
Fuqian,

> Remove the redundant initialization code.

Applied to 5.4/scsi-queue, thanks.

Patch
diff mbox series

diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index b7216d694bff..5f66a2da2599 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -1571,7 +1571,6 @@  lpfc_issue_ct_rsp(struct lpfc_hba *phba, struct bsg_job *job, uint32_t tag,
 		"2722 Xmit CT response on exchange x%x Data: x%x x%x x%x\n",
 		icmd->ulpContext, icmd->ulpIoTag, tag, phba->link_state);
 
-	ctiocb->iocb_cmpl = NULL;
 	ctiocb->iocb_flag |= LPFC_IO_LIBDFC;
 	ctiocb->vport = phba->pport;
 	ctiocb->context1 = dd_data;
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index f9e6a135d656..156224c14cc7 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -17445,7 +17445,6 @@  lpfc_sli4_seq_abort_rsp(struct lpfc_vport *vport,
 	icmd->ulpContext = phba->sli4_hba.rpi_ids[ndlp->nlp_rpi];
 	ctiocb->context1 = lpfc_nlp_get(ndlp);
 
-	ctiocb->iocb_cmpl = NULL;
 	ctiocb->vport = phba->pport;
 	ctiocb->iocb_cmpl = lpfc_sli4_seq_abort_rsp_cmpl;
 	ctiocb->sli4_lxritag = NO_XRI;