diff mbox series

[v1] Bluetooth: btqca: Reset download type to default

Message ID 20190808060737.3506-1-bgodavar@codeaurora.org (mailing list archive)
State Superseded
Headers show
Series [v1] Bluetooth: btqca: Reset download type to default | expand

Commit Message

Balakrishna Godavarthi Aug. 8, 2019, 6:07 a.m. UTC
This patch will reset the download flag to default value
before retrieving the download mode type.

Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
---
 drivers/bluetooth/btqca.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rocky Liao Aug. 8, 2019, 6:21 a.m. UTC | #1
+Claire

On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
> This patch will reset the download flag to default value
> before retrieving the download mode type.
> 
> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> ---
>  drivers/bluetooth/btqca.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 2221935fac7e..9fb247c10855 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config 
> *config,
>  	BT_DBG("Length\t\t : %d bytes", length);
> 
>  	config->dnld_mode = ROME_SKIP_EVT_NONE;
> +	config->dnld_type = ROME_SKIP_EVT_NONE;
> 
>  	switch (config->type) {
>  	case TLV_TYPE_PATCH:
Rocky Liao Aug. 8, 2019, 6:22 a.m. UTC | #2
On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
> This patch will reset the download flag to default value
> before retrieving the download mode type.
> 
> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> ---
>  drivers/bluetooth/btqca.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 2221935fac7e..9fb247c10855 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config 
> *config,
>  	BT_DBG("Length\t\t : %d bytes", length);
> 
>  	config->dnld_mode = ROME_SKIP_EVT_NONE;
> +	config->dnld_type = ROME_SKIP_EVT_NONE;
> 
>  	switch (config->type) {
>  	case TLV_TYPE_PATCH:
Claire Chang Aug. 8, 2019, 7:21 a.m. UTC | #3
Tested-by: Claire Chang <tientzu@chromium.org>

Hi,

Please add the Fixes: tag and I will add my Reviewed-by: tag.

Thanks,
Claire

On Thu, Aug 8, 2019 at 2:21 PM Rocky Liao <rjliao@codeaurora.org> wrote:
>
> +Claire
>
> On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
> > This patch will reset the download flag to default value
> > before retrieving the download mode type.
> >
> > Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> > ---
> >  drivers/bluetooth/btqca.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> > index 2221935fac7e..9fb247c10855 100644
> > --- a/drivers/bluetooth/btqca.c
> > +++ b/drivers/bluetooth/btqca.c
> > @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config
> > *config,
> >       BT_DBG("Length\t\t : %d bytes", length);
> >
> >       config->dnld_mode = ROME_SKIP_EVT_NONE;
> > +     config->dnld_type = ROME_SKIP_EVT_NONE;
> >
> >       switch (config->type) {
> >       case TLV_TYPE_PATCH:
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,
> a Linux Foundation Collaborative Project
Balakrishna Godavarthi Aug. 8, 2019, 8:57 a.m. UTC | #4
Hi,

On 2019-08-08 12:51, Claire Chang wrote:
> Tested-by: Claire Chang <tientzu@chromium.org>
> 
> Hi,
> 
> Please add the Fixes: tag and I will add my Reviewed-by: tag.
> 
> Thanks,
> Claire
> 
> On Thu, Aug 8, 2019 at 2:21 PM Rocky Liao <rjliao@codeaurora.org> 
> wrote:
>> 
>> +Claire
>> 
>> On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
>> > This patch will reset the download flag to default value
>> > before retrieving the download mode type.
>> >
>> > Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>> > ---
>> >  drivers/bluetooth/btqca.c | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>> > index 2221935fac7e..9fb247c10855 100644
>> > --- a/drivers/bluetooth/btqca.c
>> > +++ b/drivers/bluetooth/btqca.c
>> > @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config
>> > *config,
>> >       BT_DBG("Length\t\t : %d bytes", length);
>> >
>> >       config->dnld_mode = ROME_SKIP_EVT_NONE;
>> > +     config->dnld_type = ROME_SKIP_EVT_NONE;
>> >
>> >       switch (config->type) {
>> >       case TLV_TYPE_PATCH:
>> 
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project

uploaded new patch set.
diff mbox series

Patch

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index 2221935fac7e..9fb247c10855 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -140,6 +140,7 @@  static void qca_tlv_check_data(struct rome_config *config,
 	BT_DBG("Length\t\t : %d bytes", length);
 
 	config->dnld_mode = ROME_SKIP_EVT_NONE;
+	config->dnld_type = ROME_SKIP_EVT_NONE;
 
 	switch (config->type) {
 	case TLV_TYPE_PATCH: