| Message ID | 1565256353-4476-1-git-send-email-c-hbandi@codeaurora.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
| Series | [v1] Bluetooth: hci_qca: wait for Pre shutdown to command complete event before sending the Power off pulse | expand |
Hi Harish, On 2019-08-08 14:55, Harish Bandi wrote: > When SoC receives pre shut down command, it share the same > with other COEX shared clients. So SoC needs a short > time after sending VS pre shutdown command before > turning off the regulators and sending the power off pulse. > > Signed-off-by: Harish Bandi <c-hbandi@codeaurora.org> > --- > drivers/bluetooth/btqca.c | 5 +++-- > drivers/bluetooth/hci_qca.c | 2 ++ > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c > index 2221935..f20991e 100644 > --- a/drivers/bluetooth/btqca.c > +++ b/drivers/bluetooth/btqca.c > @@ -106,8 +106,9 @@ int qca_send_pre_shutdown_cmd(struct hci_dev *hdev) > > bt_dev_dbg(hdev, "QCA pre shutdown cmd"); > > - skb = __hci_cmd_sync(hdev, QCA_PRE_SHUTDOWN_CMD, 0, > - NULL, HCI_INIT_TIMEOUT); > + skb = __hci_cmd_sync_ev(hdev, QCA_PRE_SHUTDOWN_CMD, 0, > + NULL, HCI_EV_CMD_COMPLETE, HCI_INIT_TIMEOUT); [Bala]: nit: can you also add reason in commit text for adding HCI_EV_CMD_COMPLETE > + > if (IS_ERR(skb)) { > err = PTR_ERR(skb); > bt_dev_err(hdev, "QCA preshutdown_cmd failed (%d)", err); > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c > index 16db6c0..566aa28 100644 > --- a/drivers/bluetooth/hci_qca.c > +++ b/drivers/bluetooth/hci_qca.c > @@ -1386,6 +1386,8 @@ static int qca_power_off(struct hci_dev *hdev) > /* Perform pre shutdown command */ > qca_send_pre_shutdown_cmd(hdev); > > + usleep_range(8000, 10000); > + > qca_power_shutdown(hu); > return 0; > } Reviewed-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
On Thu, Aug 08, 2019 at 02:55:53PM +0530, Harish Bandi wrote: > When SoC receives pre shut down command, it share the same > with other COEX shared clients. So SoC needs a short > time after sending VS pre shutdown command before > turning off the regulators and sending the power off pulse. > > Signed-off-by: Harish Bandi <c-hbandi@codeaurora.org> > --- > drivers/bluetooth/btqca.c | 5 +++-- > drivers/bluetooth/hci_qca.c | 2 ++ > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c > index 2221935..f20991e 100644 > --- a/drivers/bluetooth/btqca.c > +++ b/drivers/bluetooth/btqca.c > @@ -106,8 +106,9 @@ int qca_send_pre_shutdown_cmd(struct hci_dev *hdev) > > bt_dev_dbg(hdev, "QCA pre shutdown cmd"); > > - skb = __hci_cmd_sync(hdev, QCA_PRE_SHUTDOWN_CMD, 0, > - NULL, HCI_INIT_TIMEOUT); > + skb = __hci_cmd_sync_ev(hdev, QCA_PRE_SHUTDOWN_CMD, 0, > + NULL, HCI_EV_CMD_COMPLETE, HCI_INIT_TIMEOUT); > + The commit message does not mention this change, it only talks about adding a delay. > if (IS_ERR(skb)) { > err = PTR_ERR(skb); > bt_dev_err(hdev, "QCA preshutdown_cmd failed (%d)", err); > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c > index 16db6c0..566aa28 100644 > --- a/drivers/bluetooth/hci_qca.c > +++ b/drivers/bluetooth/hci_qca.c > @@ -1386,6 +1386,8 @@ static int qca_power_off(struct hci_dev *hdev) > /* Perform pre shutdown command */ > qca_send_pre_shutdown_cmd(hdev); > > + usleep_range(8000, 10000); > + > qca_power_shutdown(hu); > return 0; > }
Hi Bala, On 2019-08-08 16:25, Balakrishna Godavarthi wrote: > Hi Harish, > > On 2019-08-08 14:55, Harish Bandi wrote: >> When SoC receives pre shut down command, it share the same >> with other COEX shared clients. So SoC needs a short >> time after sending VS pre shutdown command before >> turning off the regulators and sending the power off pulse. >> >> Signed-off-by: Harish Bandi <c-hbandi@codeaurora.org> >> --- >> drivers/bluetooth/btqca.c | 5 +++-- >> drivers/bluetooth/hci_qca.c | 2 ++ >> 2 files changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c >> index 2221935..f20991e 100644 >> --- a/drivers/bluetooth/btqca.c >> +++ b/drivers/bluetooth/btqca.c >> @@ -106,8 +106,9 @@ int qca_send_pre_shutdown_cmd(struct hci_dev >> *hdev) >> >> bt_dev_dbg(hdev, "QCA pre shutdown cmd"); >> >> - skb = __hci_cmd_sync(hdev, QCA_PRE_SHUTDOWN_CMD, 0, >> - NULL, HCI_INIT_TIMEOUT); >> + skb = __hci_cmd_sync_ev(hdev, QCA_PRE_SHUTDOWN_CMD, 0, >> + NULL, HCI_EV_CMD_COMPLETE, HCI_INIT_TIMEOUT); > > [Bala]: nit: can you also add reason in commit text for adding > HCI_EV_CMD_COMPLETE [Harish] - I will add reason fo HCI_EV_CMD_COMPLETE in commit text and post new patch. > >> + >> if (IS_ERR(skb)) { >> err = PTR_ERR(skb); >> bt_dev_err(hdev, "QCA preshutdown_cmd failed (%d)", err); >> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c >> index 16db6c0..566aa28 100644 >> --- a/drivers/bluetooth/hci_qca.c >> +++ b/drivers/bluetooth/hci_qca.c >> @@ -1386,6 +1386,8 @@ static int qca_power_off(struct hci_dev *hdev) >> /* Perform pre shutdown command */ >> qca_send_pre_shutdown_cmd(hdev); >> >> + usleep_range(8000, 10000); >> + >> qca_power_shutdown(hu); >> return 0; >> } > > Reviewed-by: Balakrishna Godavarthi <bgodavar@codeaurora.org> Thanks, Harish
Hi Matthias, On 2019-08-08 20:29, Matthias Kaehlcke wrote: > On Thu, Aug 08, 2019 at 02:55:53PM +0530, Harish Bandi wrote: >> When SoC receives pre shut down command, it share the same >> with other COEX shared clients. So SoC needs a short >> time after sending VS pre shutdown command before >> turning off the regulators and sending the power off pulse. >> >> Signed-off-by: Harish Bandi <c-hbandi@codeaurora.org> >> --- >> drivers/bluetooth/btqca.c | 5 +++-- >> drivers/bluetooth/hci_qca.c | 2 ++ >> 2 files changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c >> index 2221935..f20991e 100644 >> --- a/drivers/bluetooth/btqca.c >> +++ b/drivers/bluetooth/btqca.c >> @@ -106,8 +106,9 @@ int qca_send_pre_shutdown_cmd(struct hci_dev >> *hdev) >> >> bt_dev_dbg(hdev, "QCA pre shutdown cmd"); >> >> - skb = __hci_cmd_sync(hdev, QCA_PRE_SHUTDOWN_CMD, 0, >> - NULL, HCI_INIT_TIMEOUT); >> + skb = __hci_cmd_sync_ev(hdev, QCA_PRE_SHUTDOWN_CMD, 0, >> + NULL, HCI_EV_CMD_COMPLETE, HCI_INIT_TIMEOUT); >> + > > The commit message does not mention this change, it only talks about > adding a delay. [Harish] - I will add reason fo HCI_EV_CMD_COMPLETE in commit text and post new patch. In commit text title I mentioned about command complete event, However I will add more details about reason for command complete in commit text > >> if (IS_ERR(skb)) { >> err = PTR_ERR(skb); >> bt_dev_err(hdev, "QCA preshutdown_cmd failed (%d)", err); >> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c >> index 16db6c0..566aa28 100644 >> --- a/drivers/bluetooth/hci_qca.c >> +++ b/drivers/bluetooth/hci_qca.c >> @@ -1386,6 +1386,8 @@ static int qca_power_off(struct hci_dev *hdev) >> /* Perform pre shutdown command */ >> qca_send_pre_shutdown_cmd(hdev); >> >> + usleep_range(8000, 10000); >> + >> qca_power_shutdown(hu); >> return 0; >> }
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index 2221935..f20991e 100644 --- a/drivers/bluetooth/btqca.c +++ b/drivers/bluetooth/btqca.c @@ -106,8 +106,9 @@ int qca_send_pre_shutdown_cmd(struct hci_dev *hdev) bt_dev_dbg(hdev, "QCA pre shutdown cmd"); - skb = __hci_cmd_sync(hdev, QCA_PRE_SHUTDOWN_CMD, 0, - NULL, HCI_INIT_TIMEOUT); + skb = __hci_cmd_sync_ev(hdev, QCA_PRE_SHUTDOWN_CMD, 0, + NULL, HCI_EV_CMD_COMPLETE, HCI_INIT_TIMEOUT); + if (IS_ERR(skb)) { err = PTR_ERR(skb); bt_dev_err(hdev, "QCA preshutdown_cmd failed (%d)", err); diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 16db6c0..566aa28 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1386,6 +1386,8 @@ static int qca_power_off(struct hci_dev *hdev) /* Perform pre shutdown command */ qca_send_pre_shutdown_cmd(hdev); + usleep_range(8000, 10000); + qca_power_shutdown(hu); return 0; }
When SoC receives pre shut down command, it share the same with other COEX shared clients. So SoC needs a short time after sending VS pre shutdown command before turning off the regulators and sending the power off pulse. Signed-off-by: Harish Bandi <c-hbandi@codeaurora.org> --- drivers/bluetooth/btqca.c | 5 +++-- drivers/bluetooth/hci_qca.c | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-)