| Message ID | 20190808151150.16336-6-boris.brezillon@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Add support for bus-format negotiation | expand |
On Thu, 8 Aug 2019 17:11:36 +0200 Boris Brezillon <boris.brezillon@collabora.com> wrote: > bridge->next is only points to the new bridge if drm_bridge_attach() ^/is// > succeeds. No need to reset it manually here. > > Note that this change is part of the attempt to make the bridge chain > a double-linked list. In order to do that we must patch all drivers > manipulating the bridge->next field. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/gpu/drm/exynos/exynos_dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c > index 1e6aa24bf45e..4785885c0f4f 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp.c > +++ b/drivers/gpu/drm/exynos/exynos_dp.c > @@ -110,7 +110,6 @@ static int exynos_dp_bridge_attach(struct analogix_dp_plat_data *plat_data, > if (ret) { > DRM_DEV_ERROR(dp->dev, > "Failed to attach bridge to drm\n"); > - bridge->next = NULL; > return ret; > } > }
Hi Boris, On Thu, Aug 08, 2019 at 05:11:36PM +0200, Boris Brezillon wrote: > bridge->next is only points to the new bridge if drm_bridge_attach() > succeeds. No need to reset it manually here. > > Note that this change is part of the attempt to make the bridge chain > a double-linked list. In order to do that we must patch all drivers > manipulating the bridge->next field. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> This looks good to me as a cleanup, and I think you can already push it without waiting for the whole series to be ready. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/exynos/exynos_dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c > index 1e6aa24bf45e..4785885c0f4f 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp.c > +++ b/drivers/gpu/drm/exynos/exynos_dp.c > @@ -110,7 +110,6 @@ static int exynos_dp_bridge_attach(struct analogix_dp_plat_data *plat_data, > if (ret) { > DRM_DEV_ERROR(dp->dev, > "Failed to attach bridge to drm\n"); > - bridge->next = NULL; > return ret; > } > }
diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index 1e6aa24bf45e..4785885c0f4f 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -110,7 +110,6 @@ static int exynos_dp_bridge_attach(struct analogix_dp_plat_data *plat_data, if (ret) { DRM_DEV_ERROR(dp->dev, "Failed to attach bridge to drm\n"); - bridge->next = NULL; return ret; } }
bridge->next is only points to the new bridge if drm_bridge_attach() succeeds. No need to reset it manually here. Note that this change is part of the attempt to make the bridge chain a double-linked list. In order to do that we must patch all drivers manipulating the bridge->next field. Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> --- drivers/gpu/drm/exynos/exynos_dp.c | 1 - 1 file changed, 1 deletion(-)