From patchwork Fri Aug 9 01:21:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 11085107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C65A9912 for ; Fri, 9 Aug 2019 01:35:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B4BD6288B7 for ; Fri, 9 Aug 2019 01:35:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A85A228994; Fri, 9 Aug 2019 01:35:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 58990288B7 for ; Fri, 9 Aug 2019 01:35:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 202082130A500; Thu, 8 Aug 2019 18:38:14 -0700 (PDT) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=dan.j.williams@intel.com; receiver=linux-nvdimm@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B399B21309D22 for ; Thu, 8 Aug 2019 18:38:12 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 18:35:38 -0700 X-IronPort-AV: E=Sophos;i="5.64,363,1559545200"; d="scan'208";a="350362602" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 18:35:38 -0700 Subject: [ndctl PATCH] ndctl/test: Add xfs reflink dependency From: Dan Williams To: linux-nvdimm@lists.01.org Date: Thu, 08 Aug 2019 18:21:21 -0700 Message-ID: <156531368129.2136155.4247732841095137080.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.18-2-gc94f MIME-Version: 1.0 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Virus-Scanned: ClamAV using ClamSMTP Starting with xfsprogs version 5.1.0 it will enable reflink by default. Any scripts, like ndctl unit tests, that were doing: mkfs.xfs $pmem; mount -o dax $pmem $mnt ...must now do: mkfs.xfs -m reflink=0 $pmem; mount -o dax $pmem $mnt Cc: Jeff Moyer Signed-off-by: Dan Williams Acked-by: Jeff Moyer --- test/dax.sh | 4 ++-- test/mmap.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/dax.sh b/test/dax.sh index e703e1222dee..3bb44ac0a26c 100755 --- a/test/dax.sh +++ b/test/dax.sh @@ -69,7 +69,7 @@ json=$($NDCTL create-namespace -m raw -f -e $dev) eval $(json2var <<< "$json") [ $mode != "fsdax" ] && echo "fail: $LINENO" && exit 1 -mkfs.xfs -f /dev/$blockdev +mkfs.xfs -f /dev/$blockdev -m reflink=0 mount /dev/$blockdev $MNT -o dax fallocate -l 1GiB $MNT/$FILE run_test @@ -80,7 +80,7 @@ json=$($NDCTL create-namespace -m fsdax -M dev -f -e $dev) eval $(json2var <<< "$json") [ $mode != "fsdax" ] && echo "fail: $LINENO" && exit 1 -mkfs.xfs -f /dev/$blockdev +mkfs.xfs -f /dev/$blockdev -m reflink=0 mount /dev/$blockdev $MNT -o dax fallocate -l 1GiB $MNT/$FILE run_test diff --git a/test/mmap.sh b/test/mmap.sh index afe50fd2199b..d072ea289f31 100755 --- a/test/mmap.sh +++ b/test/mmap.sh @@ -70,7 +70,7 @@ fallocate -l 1GiB $MNT/$FILE test_mmap umount $MNT -mkfs.xfs -f $DEV +mkfs.xfs -f $DEV -m reflink=0 mount $DEV $MNT -o dax fallocate -l 1GiB $MNT/$FILE test_mmap