fix odd_ptr_err.cocci warnings
diff mbox series

Message ID alpine.DEB.2.21.1908091229140.2946@hadrien
State New
Headers show
Series
  • fix odd_ptr_err.cocci warnings
Related show

Commit Message

Julia Lawall Aug. 9, 2019, 10:30 a.m. UTC
From: kbuild test robot <lkp@intel.com>

 PTR_ERR should normally access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Fixes: 62c9c1442c8f ("j721e new machine driver wip")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago

 j721e-evm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mark Brown Aug. 9, 2019, 12:31 p.m. UTC | #1
On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:

> tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
> head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
> :::::: branch date: 20 hours ago
> :::::: commit date: 20 hours ago
> 
>  j721e-evm.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/sound/soc/ti/j721e-evm.c
> +++ b/sound/soc/ti/j721e-evm.c
> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf

This file isn't upstream, it's only in the TI BSP.
Peter Ujfalusi Aug. 9, 2019, 1:14 p.m. UTC | #2
On 09/08/2019 15.31, Mark Brown wrote:
> On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
> 
>> tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
>> head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
>> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
>> :::::: branch date: 20 hours ago
>> :::::: commit date: 20 hours ago
>>
>>  j721e-evm.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --- a/sound/soc/ti/j721e-evm.c
>> +++ b/sound/soc/ti/j721e-evm.c
>> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
> 
> This file isn't upstream, it's only in the TI BSP.

Yes, it is not upstream, but the fix is valid.

Julia: is it possible to direct these notifications only to me from
https://github.com/omap-audio/linux-audio.git ?

It mostly carries TI BSP stuff and my various for upstream branches nowdays.

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Julia Lawall Aug. 9, 2019, 1:21 p.m. UTC | #3
On Fri, 9 Aug 2019, Peter Ujfalusi wrote:

>
>
> On 09/08/2019 15.31, Mark Brown wrote:
> > On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
> >
> >> tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
> >> head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
> >> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
> >> :::::: branch date: 20 hours ago
> >> :::::: commit date: 20 hours ago
> >>
> >>  j721e-evm.c |    4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> --- a/sound/soc/ti/j721e-evm.c
> >> +++ b/sound/soc/ti/j721e-evm.c
> >> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
> >
> > This file isn't upstream, it's only in the TI BSP.
>
> Yes, it is not upstream, but the fix is valid.
>
> Julia: is it possible to direct these notifications only to me from
> https://github.com/omap-audio/linux-audio.git ?
>
> It mostly carries TI BSP stuff and my various for upstream branches nowdays.

Please discuss it with the kbuild people.  They should be able to set it
up as you want.

You can try lkp@intel.com

julia
Rong Chen Aug. 20, 2019, 8:41 a.m. UTC | #4
Hi Peter,

We have updated to only send the reports to you, please see 
https://github.com/intel/lkp-tests/blob/master/repo/linux/omap-audio

Best Regards,
Rong Chen

On 8/9/19 9:21 PM, Julia Lawall wrote:
>
> On Fri, 9 Aug 2019, Peter Ujfalusi wrote:
>
>>
>> On 09/08/2019 15.31, Mark Brown wrote:
>>> On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
>>>
>>>> tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
>>>> head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
>>>> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
>>>> :::::: branch date: 20 hours ago
>>>> :::::: commit date: 20 hours ago
>>>>
>>>>   j721e-evm.c |    4 ++--
>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> --- a/sound/soc/ti/j721e-evm.c
>>>> +++ b/sound/soc/ti/j721e-evm.c
>>>> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
>>> This file isn't upstream, it's only in the TI BSP.
>> Yes, it is not upstream, but the fix is valid.
>>
>> Julia: is it possible to direct these notifications only to me from
>> https://github.com/omap-audio/linux-audio.git ?
>>
>> It mostly carries TI BSP stuff and my various for upstream branches nowdays.
> Please discuss it with the kbuild people.  They should be able to set it
> up as you want.
>
> You can try lkp@intel.com
>
> julia
> _______________________________________________
> kbuild-all mailing list
> kbuild-all@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all
Peter Ujfalusi Aug. 20, 2019, 10:54 a.m. UTC | #5
Hi Chen,

On 20/08/2019 11.41, Rong Chen wrote:
> Hi Peter,
> 
> We have updated to only send the reports to you, please see
> https://github.com/intel/lkp-tests/blob/master/repo/linux/omap-audio

Thank you very much!

> 
> Best Regards,
> Rong Chen
> 
> On 8/9/19 9:21 PM, Julia Lawall wrote:
>>
>> On Fri, 9 Aug 2019, Peter Ujfalusi wrote:
>>
>>>
>>> On 09/08/2019 15.31, Mark Brown wrote:
>>>> On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
>>>>
>>>>> tree:   https://github.com/omap-audio/linux-audio
>>>>> peter/ti-linux-4.19.y/wip
>>>>> head:   62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
>>>>> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new
>>>>> machine driver wip
>>>>> :::::: branch date: 20 hours ago
>>>>> :::::: commit date: 20 hours ago
>>>>>
>>>>>   j721e-evm.c |    4 ++--
>>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> --- a/sound/soc/ti/j721e-evm.c
>>>>> +++ b/sound/soc/ti/j721e-evm.c
>>>>> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
>>>> This file isn't upstream, it's only in the TI BSP.
>>> Yes, it is not upstream, but the fix is valid.
>>>
>>> Julia: is it possible to direct these notifications only to me from
>>> https://github.com/omap-audio/linux-audio.git ?
>>>
>>> It mostly carries TI BSP stuff and my various for upstream branches
>>> nowdays.
>> Please discuss it with the kbuild people.  They should be able to set it
>> up as you want.
>>
>> You can try lkp@intel.com
>>
>> julia
>> _______________________________________________
>> kbuild-all mailing list
>> kbuild-all@lists.01.org
>> https://lists.01.org/mailman/listinfo/kbuild-all
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Patch
diff mbox series

--- a/sound/soc/ti/j721e-evm.c
+++ b/sound/soc/ti/j721e-evm.c
@@ -283,7 +283,7 @@  static int j721e_get_clocks(struct platf
 		parent = devm_clk_get(&pdev->dev, clk_name);
 		kfree(clk_name);
 		if (IS_ERR(parent)) {
-			ret = PTR_ERR(clocks->parent);
+			ret = PTR_ERR(parent);
 			if (ret != -EPROBE_DEFER)
 				dev_err(&pdev->dev, "failed to acquire %s': %d\n",
 					prefix, ret);
@@ -299,7 +299,7 @@  static int j721e_get_clocks(struct platf
 		parent = devm_clk_get(&pdev->dev, clk_name);
 		kfree(clk_name);
 		if (IS_ERR(parent)) {
-			ret = PTR_ERR(clocks->parent);
+			ret = PTR_ERR(parent);
 			if (ret != -EPROBE_DEFER)
 				dev_err(&pdev->dev, "failed to acquire %s': %d\n",
 					prefix, ret);