| Message ID | 20190809112853.15846-5-stefan-gabriel.mirea@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add initial support for S32V234-EVB | expand |
On Fri, Aug 09, 2019 at 11:29:14AM +0000, Stefan-gabriel Mirea wrote: > From: Stoica Cosmin-Stefan <cosmin.stoica@nxp.com> > > Add documentation for the serial communication interface module (LINFlex), > found in two instances on S32V234. > > Signed-off-by: Stoica Cosmin-Stefan <cosmin.stoica@nxp.com> > Signed-off-by: Larisa Grigore <Larisa.Grigore@nxp.com> > Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com> > --- > .../bindings/serial/fsl,s32-linflexuart.txt | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt > > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt > new file mode 100644 > index 000000000000..957ffeaca9f1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt > @@ -0,0 +1,24 @@ > +* Freescale Linflex UART Be consistent with the name: LINFlexD? > + > +The LINFlexD controller implements several LIN protocol versions, as well as > +support for full-duplex UART communication through 8-bit and 9-bit frames. The > +Linflex UART driver enables operation only in UART mode. What the driver supports or not is independent of the binding. > + > +See chapter 47 ("LINFlexD") in the reference manual[1]. > + > +Required properties: > +- compatible : > + - "fsl,s32-linflexuart" for linflex configured in uart mode which LINFlexD? > + is compatible with the one integrated on S32V234 SoC Compatibles should be SoC specific. Is 's32' specific enough to account for any differences or future bugs found? > +- reg : Address and length of the register set for the device > +- interrupts : Should contain uart interrupt > + > +Example: > +uart0:serial@40053000 { space ^ > + compatible = "fsl,s32-linflexuart"; > + reg = <0x0 0x40053000 0x0 0x1000>; > + interrupts = <0 59 4>; > + status = "disabled"; Don't show status in examples. > +}; > + > +[1] https://www.nxp.com/webapp/Download?colCode=S32V234RM > -- > 2.22.0 >
Hello Rob, Thank you for the review. On 8/22/2019 12:18 AM, Rob Herring wrote: > On Fri, Aug 09, 2019 at 11:29:14AM +0000, Stefan-gabriel Mirea wrote: >> +* Freescale Linflex UART > > Be consistent with the name: LINFlexD? This was also brought up in our internal review. However, the reference manual is also inconsistent, using LINFlexD, LINflexD, LinFlexD, LINFlex, LINFLEX, LinFlex and Linflex. I will switch to 'LINFlexD' everywhere, though. >> +The LINFlexD controller implements several LIN protocol versions, as well as >> +support for full-duplex UART communication through 8-bit and 9-bit frames. The >> +Linflex UART driver enables operation only in UART mode. > > What the driver supports or not is independent of the binding. Ok, I will remove the last sentence ("The Linflex UART driver enables operation only in UART mode"). >> + - "fsl,s32-linflexuart" for linflex configured in uart mode which > > LINFlexD? Will fix; I agree that the all lowercase version has no occurrence in the reference manual. >> + is compatible with the one integrated on S32V234 SoC > > Compatibles should be SoC specific. Is 's32' specific enough to account > for any differences or future bugs found? It is probably not. I will change it to "fsl,s32v234-linflexuart" (as well as in the device tree and driver). >> +Example: >> +uart0:serial@40053000 { > > space ^ > >> + compatible = "fsl,s32-linflexuart"; >> + reg = <0x0 0x40053000 0x0 0x1000>; >> + interrupts = <0 59 4>; >> + status = "disabled"; > > Don't show status in examples. Will fix these too. Regards, Stefan
diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt new file mode 100644 index 000000000000..957ffeaca9f1 --- /dev/null +++ b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt @@ -0,0 +1,24 @@ +* Freescale Linflex UART + +The LINFlexD controller implements several LIN protocol versions, as well as +support for full-duplex UART communication through 8-bit and 9-bit frames. The +Linflex UART driver enables operation only in UART mode. + +See chapter 47 ("LINFlexD") in the reference manual[1]. + +Required properties: +- compatible : + - "fsl,s32-linflexuart" for linflex configured in uart mode which + is compatible with the one integrated on S32V234 SoC +- reg : Address and length of the register set for the device +- interrupts : Should contain uart interrupt + +Example: +uart0:serial@40053000 { + compatible = "fsl,s32-linflexuart"; + reg = <0x0 0x40053000 0x0 0x1000>; + interrupts = <0 59 4>; + status = "disabled"; +}; + +[1] https://www.nxp.com/webapp/Download?colCode=S32V234RM