arm64: dts: rockchip: Enable internal SPI flash for RockPro64.
diff mbox series

Message ID 20190811211108.28071-1-andrius@stikonas.eu
State New
Headers show
Series
  • arm64: dts: rockchip: Enable internal SPI flash for RockPro64.
Related show

Commit Message

Andrius Štikonas Aug. 11, 2019, 9:11 p.m. UTC
Signed-off-by: Andrius Štikonas <andrius@stikonas.eu>
---
 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Heiko Stuebner Aug. 16, 2019, 11:56 a.m. UTC | #1
Hi Andrius,

I did apply this patch for 5.4 ... with a big but ...
Meaning I did quite a number of changes as described below
and would ask you to keep them in mind for future patches.

So there is no need to resend a fixed version of this patch.

(1) Please also include other lists, scripts/get_maintainer.pl is a good
starting point. linux-rockchip alone feels like hiding the patch ;-) .

Am Sonntag, 11. August 2019, 23:11:08 CEST schrieb Andrius Štikonas:

(2) Please always provide a patch descripton of some sort, I did go with
	"The rockpro64 contains a nor-flash chip connected to spi1."

> Signed-off-by: Andrius Štikonas <andrius@stikonas.eu>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> index eb5594062006..abc97b2c1f18 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> @@ -611,6 +611,20 @@
>  	status = "okay";
>  };
>  
> +&spi1 {

(3) please sort nodes alphabetically, so here this should be between
&sdio and &tcphy0

(4) All indentation of the lines below was done with spaces, please use tabs.

> +       status = "okay";
> +       max-freq = <10000000>;


(5) This property is not part of any binding and also not used, so dropped

> +
> +       flash@0 {
> +               compatible = "jedec,spi-nor";
> +               #address-cells = <1>;
> +               #size-cells = <1>;

(6) There is no need at all for the #foo-cells here, they're not part of the
binding and also not used.

> +               reg = <0>;
> +               spi-max-frequency = <10000000>;
> +       };
> +};
> +
> +

(7) Please make sure to not include double empty lines, this should only be
one between nodes.


Thanks
Heiko

>  &sdmmc {
>  	bus-width = <4>;
>  	cap-mmc-highspeed;
>

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
index eb5594062006..abc97b2c1f18 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
@@ -611,6 +611,20 @@ 
 	status = "okay";
 };
 
+&spi1 {
+       status = "okay";
+       max-freq = <10000000>;
+
+       flash@0 {
+               compatible = "jedec,spi-nor";
+               #address-cells = <1>;
+               #size-cells = <1>;
+               reg = <0>;
+               spi-max-frequency = <10000000>;
+       };
+};
+
+
 &sdmmc {
 	bus-width = <4>;
 	cap-mmc-highspeed;