From patchwork Mon Aug 12 21:34:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Palmer Dabbelt X-Patchwork-Id: 11090909 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3B1914F7 for ; Mon, 12 Aug 2019 21:35:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C4CAA1FF82 for ; Mon, 12 Aug 2019 21:35:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B8A7E26E54; Mon, 12 Aug 2019 21:35:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E20C1FF82 for ; Mon, 12 Aug 2019 21:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726806AbfHLVfr (ORCPT ); Mon, 12 Aug 2019 17:35:47 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:38684 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727037AbfHLVfq (ORCPT ); Mon, 12 Aug 2019 17:35:46 -0400 Received: by mail-pg1-f196.google.com with SMTP id z14so12902160pga.5 for ; Mon, 12 Aug 2019 14:35:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:cc:from:to; bh=YY96A52tihJFS6J0AenEACSrUCVrg3kxBvzolC3vf40=; b=rTU0G61e+TZDdTbFi8q804oO2w6q+nz2tP7BHOoU3cmdS4rNRpWEcDJa00CsLcAnTi G0487alp/gatT12jcpUp8esK9G2uwUHJaWYGWs0puMOYAkVLZDfftQvA+fiJ4qkcN/36 5YWRU+Cqp0mvgvyjdvWjhOX3GQi42ejy1I2h3b/MfyZ39QOj3LF3YzOP4VpitBtesqbk c9OroldAASRzOmUxB24lrgxX/MXTk6b2KcY7DVuJN3lCD3saUWlTHnxOWSNvNN0QU4Ab U7wyvo5fijp0hGCHOtXm4tFT+vsUQxA527o4scflZe815lRCs7ZVzetMEV1S/HES4Zkz JsqA== X-Gm-Message-State: APjAAAX61K8AMkGlzBH3yB6kUy9abOJikS+v8BwFH/Eif97SNbA04MNT 55Mm9bdy1GHtFFiu9nuPMmBNWw== X-Google-Smtp-Source: APXvYqzv+P+Td1ArzqfoVe3POp02XfndSSKSJ3IsdKMZyMO/mccFvAwjKdpUYJWhF/Tct+5QYkWbKQ== X-Received: by 2002:aa7:8007:: with SMTP id j7mr37282311pfi.154.1565645745605; Mon, 12 Aug 2019 14:35:45 -0700 (PDT) Received: from localhost ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id v63sm112254216pfv.174.2019.08.12.14.35.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 12 Aug 2019 14:35:44 -0700 (PDT) Subject: [PATCH v2 3/5] fetch: Add the fetch.jobs config key Date: Mon, 12 Aug 2019 14:34:46 -0700 Message-Id: <20190812213448.2649-4-palmer@sifive.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190812213448.2649-1-palmer@sifive.com> References: <20190812213448.2649-1-palmer@sifive.com> MIME-Version: 1.0 Cc: peff@peff.net, e@80x24.org, chriscool@tuxfamily.org, gitster@pobox.com, jonathantanmy@google.com, tboegi@web.de, bwilliams.eng@gmail.com, jeffhost@microsoft.com, Palmer Dabbelt From: Palmer Dabbelt To: git@vger.kernel.org Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This allows users to default to parallel fetches, so they don't have to pass --fetch-jobs=N on the command line every time. The implementation matches submodule.fetchjobs by die()ing on invalid job counts. I couldn't find any documentation for submodule.fetchjobs, so I didn't write any for this one. I've tested this in my config and in conjunction with the command-line argument. Signed-off-by: Palmer Dabbelt --- builtin/fetch.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/builtin/fetch.c b/builtin/fetch.c index fa12ad44e7d9..4c5f2ea3a931 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -104,6 +104,13 @@ static int git_fetch_config(const char *k, const char *v, void *cb) return 0; } + if (!strcmp(k, "fetch.jobs")) { + max_children_for_fetch = git_config_int(k, v); + if (max_children_for_fetch < 0) + die(_("negative values not allowed for fetch.jobs")); + return 0; + } + return git_default_config(k, v, cb); }