dmaengine: dw: Update Intel Elkhart Lake Service Engine acronym
diff mbox series

Message ID 20190813080602.15376-1-jarkko.nikula@linux.intel.com
State Accepted
Headers show
Series
  • dmaengine: dw: Update Intel Elkhart Lake Service Engine acronym
Related show

Commit Message

Jarkko Nikula Aug. 13, 2019, 8:06 a.m. UTC
Intel Elkhart Lake Offload Service Engine (OSE) will be called as
Intel(R) Programmable Services Engine (Intel(R) PSE) in documentation.

Update the comment here accordingly.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
 drivers/dma/dw/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko Aug. 13, 2019, 2:07 p.m. UTC | #1
On Tue, Aug 13, 2019 at 11:06:02AM +0300, Jarkko Nikula wrote:
> Intel Elkhart Lake Offload Service Engine (OSE) will be called as
> Intel(R) Programmable Services Engine (Intel(R) PSE) in documentation.
> 
> Update the comment here accordingly.

Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Seems similar we need for UART.

> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
>  drivers/dma/dw/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dw/pci.c b/drivers/dma/dw/pci.c
> index 8de87b15a988..ad6db1cc287e 100644
> --- a/drivers/dma/dw/pci.c
> +++ b/drivers/dma/dw/pci.c
> @@ -143,7 +143,7 @@ static const struct pci_device_id dw_pci_id_table[] = {
>  	{ PCI_VDEVICE(INTEL, 0x2286), (kernel_ulong_t)&dw_pci_data },
>  	{ PCI_VDEVICE(INTEL, 0x22c0), (kernel_ulong_t)&dw_pci_data },
>  
> -	/* Elkhart Lake iDMA 32-bit (OSE DMA) */
> +	/* Elkhart Lake iDMA 32-bit (PSE DMA) */
>  	{ PCI_VDEVICE(INTEL, 0x4bb4), (kernel_ulong_t)&idma32_pci_data },
>  	{ PCI_VDEVICE(INTEL, 0x4bb5), (kernel_ulong_t)&idma32_pci_data },
>  	{ PCI_VDEVICE(INTEL, 0x4bb6), (kernel_ulong_t)&idma32_pci_data },
> -- 
> 2.20.1
>
Jarkko Nikula Aug. 13, 2019, 2:17 p.m. UTC | #2
On 8/13/19 5:07 PM, Andy Shevchenko wrote:
> On Tue, Aug 13, 2019 at 11:06:02AM +0300, Jarkko Nikula wrote:
>> Intel Elkhart Lake Offload Service Engine (OSE) will be called as
>> Intel(R) Programmable Services Engine (Intel(R) PSE) in documentation.
>>
>> Update the comment here accordingly.
> 
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Seems similar we need for UART.
> 
You mean a0d993e8c143 ("serial: 8250_lpss: Enable HS UART on Elkhart 
Lake")? No Code or comment on that commit mention OSE, only commit log.
Andy Shevchenko Aug. 13, 2019, 2:45 p.m. UTC | #3
On Tue, Aug 13, 2019 at 05:17:24PM +0300, Jarkko Nikula wrote:
> On 8/13/19 5:07 PM, Andy Shevchenko wrote:
> > On Tue, Aug 13, 2019 at 11:06:02AM +0300, Jarkko Nikula wrote:
> > > Intel Elkhart Lake Offload Service Engine (OSE) will be called as
> > > Intel(R) Programmable Services Engine (Intel(R) PSE) in documentation.
> > > 
> > > Update the comment here accordingly.
> > 
> > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > Seems similar we need for UART.
> > 
> You mean a0d993e8c143 ("serial: 8250_lpss: Enable HS UART on Elkhart Lake")?
> No Code or comment on that commit mention OSE, only commit log.

Ah, we can't fix commit messages.
Thanks for checking!
Viresh Kumar Aug. 19, 2019, 8:32 a.m. UTC | #4
On 13-08-19, 11:06, Jarkko Nikula wrote:
> Intel Elkhart Lake Offload Service Engine (OSE) will be called as
> Intel(R) Programmable Services Engine (Intel(R) PSE) in documentation.
> 
> Update the comment here accordingly.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
>  drivers/dma/dw/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Vinod Koul Aug. 20, 2019, 11:09 a.m. UTC | #5
On 13-08-19, 11:06, Jarkko Nikula wrote:
> Intel Elkhart Lake Offload Service Engine (OSE) will be called as
> Intel(R) Programmable Services Engine (Intel(R) PSE) in documentation.
> 
> Update the comment here accordingly.

Applied, thanks

Patch
diff mbox series

diff --git a/drivers/dma/dw/pci.c b/drivers/dma/dw/pci.c
index 8de87b15a988..ad6db1cc287e 100644
--- a/drivers/dma/dw/pci.c
+++ b/drivers/dma/dw/pci.c
@@ -143,7 +143,7 @@  static const struct pci_device_id dw_pci_id_table[] = {
 	{ PCI_VDEVICE(INTEL, 0x2286), (kernel_ulong_t)&dw_pci_data },
 	{ PCI_VDEVICE(INTEL, 0x22c0), (kernel_ulong_t)&dw_pci_data },
 
-	/* Elkhart Lake iDMA 32-bit (OSE DMA) */
+	/* Elkhart Lake iDMA 32-bit (PSE DMA) */
 	{ PCI_VDEVICE(INTEL, 0x4bb4), (kernel_ulong_t)&idma32_pci_data },
 	{ PCI_VDEVICE(INTEL, 0x4bb5), (kernel_ulong_t)&idma32_pci_data },
 	{ PCI_VDEVICE(INTEL, 0x4bb6), (kernel_ulong_t)&idma32_pci_data },