[PATCHv3] zd1211rw: remove false assertion from zd_mac_clear()
diff mbox series

Message ID 20190813120412.6240-1-oneukum@suse.com
State Accepted
Commit 7a2eb7367fdea72e448d1a847aa857f6caf8ea2f
Delegated to: Kalle Valo
Headers show
Series
  • [PATCHv3] zd1211rw: remove false assertion from zd_mac_clear()
Related show

Commit Message

Oliver Neukum Aug. 13, 2019, 12:04 p.m. UTC
The function is called before the lock which is asserted was ever used.
Just remove it.

V2: correct CCs
V3: correct name

Reported-by: syzbot+74c65761783d66a9c97c@syzkaller.appspotmail.com
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
 drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Kalle Valo Sept. 3, 2019, 1:39 p.m. UTC | #1
Oliver Neukum <oneukum@suse.com> wrote:

> The function is called before the lock which is asserted was ever used.
> Just remove it.
> 
> Reported-by: syzbot+74c65761783d66a9c97c@syzkaller.appspotmail.com
> Signed-off-by: Oliver Neukum <oneukum@suse.com>

Patch applied to wireless-drivers-next.git, thanks.

7a2eb7367fde zd1211rw: remove false assertion from zd_mac_clear()

Patch
diff mbox series

diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
index da7e63fca9f5..a9999d10ae81 100644
--- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
@@ -223,7 +223,6 @@  void zd_mac_clear(struct zd_mac *mac)
 {
 	flush_workqueue(zd_workqueue);
 	zd_chip_clear(&mac->chip);
-	lockdep_assert_held(&mac->lock);
 	ZD_MEMCLEAR(mac, sizeof(struct zd_mac));
 }