[1/2] ALSA: hda - Let all conexant codec enter D3 when rebooting
diff mbox series

Message ID 20190814040908.9758-1-hui.wang@canonical.com
State New
Headers show
Series
  • [1/2] ALSA: hda - Let all conexant codec enter D3 when rebooting
Related show

Commit Message

Hui Wang Aug. 14, 2019, 4:09 a.m. UTC
We have 3 new lenovo laptops which have conexant codec 0x14f11f86,
these 3 laptops also have the noise issue when rebooting, after
letting the codec enter D3 before rebooting or poweroff, the noise
disappers.

Instead of adding a new ID again in the reboot_notify(), let us make
this function apply to all conexant codec. In theory make codec enter
D3 before rebooting or poweroff is harmless, and I tested this change
on a couple of other Lenovo laptops which have different conexant
codecs, there is no side effect so far.

Cc: stable@vger.kernel.org
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_conexant.c | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Takashi Iwai Aug. 14, 2019, 6:39 a.m. UTC | #1
On Wed, 14 Aug 2019 06:09:07 +0200,
Hui Wang wrote:
> 
> We have 3 new lenovo laptops which have conexant codec 0x14f11f86,
> these 3 laptops also have the noise issue when rebooting, after
> letting the codec enter D3 before rebooting or poweroff, the noise
> disappers.
> 
> Instead of adding a new ID again in the reboot_notify(), let us make
> this function apply to all conexant codec. In theory make codec enter
> D3 before rebooting or poweroff is harmless, and I tested this change
> on a couple of other Lenovo laptops which have different conexant
> codecs, there is no side effect so far.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Applied, thanks.


Takashi

Patch
diff mbox series

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index f299f137eaea..93a303676aea 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -163,15 +163,6 @@  static void cx_auto_reboot_notify(struct hda_codec *codec)
 {
 	struct conexant_spec *spec = codec->spec;
 
-	switch (codec->core.vendor_id) {
-	case 0x14f12008: /* CX8200 */
-	case 0x14f150f2: /* CX20722 */
-	case 0x14f150f4: /* CX20724 */
-		break;
-	default:
-		return;
-	}
-
 	/* Turn the problematic codec into D3 to avoid spurious noises
 	   from the internal speaker during (and after) reboot */
 	cx_auto_turn_eapd(codec, spec->num_eapds, spec->eapds, false);