From patchwork Wed Aug 14 20:20:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11094475 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 655B61395 for ; Wed, 14 Aug 2019 20:20:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5531028800 for ; Wed, 14 Aug 2019 20:20:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 495B028837; Wed, 14 Aug 2019 20:20:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CFF0E28800 for ; Wed, 14 Aug 2019 20:20:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFB026E833; Wed, 14 Aug 2019 20:20:44 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ADF86E832 for ; Wed, 14 Aug 2019 20:20:42 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id p28so372978edi.3 for ; Wed, 14 Aug 2019 13:20:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8YdsxBm4SorcCs6LR7QkyWK07j5ac679kdHnkcCO8NA=; b=MpI+K0fxcqGNqHuqbJ6cMfmgz2emqJpoKAd8IXt/YNGs1XR+EZuRm696zjE7JGvJhe dpB9EJcTT3bEXGfjBjAawgEBOZAw9NlBaq7aoOXnd2wLrDSz6sLTb4XsUcXspH9OndGW YIRRLw9TCNseq31D4/z+N6sYxDh8l5ryCsuYwONd+LnP1Eu9SH60WZ4Zb7KYHS8Lsx5S A2nY4GtvzRILjkY1hYQshU6yitI6VqHHpf6ivSm2MFaI6MQu7XB/p6cR6bImss5NAM8I R0A4g2QgrWeOvJqoqeTgAO5uWNAMTauolstu0WbMe649zUcAexW3bO/zsrqqsLpmHsfC 3n3A== X-Gm-Message-State: APjAAAXrruy19yFzlbyue+VhsiDgS48AXwqPuanE7WMt7AeL1k2X8bTF jYL0KS+tnN7pDF70hpUjXDqrTQ== X-Google-Smtp-Source: APXvYqyP95CvDgYSo4eGFz7IoA7gCAiTTQNCbZZ85IgUxdxzhynRxhcbBwMwFB/O5KsYTtdIbvM0uQ== X-Received: by 2002:aa7:d285:: with SMTP id w5mr1658562edq.134.1565814040425; Wed, 14 Aug 2019 13:20:40 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id ns22sm84342ejb.9.2019.08.14.13.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2019 13:20:39 -0700 (PDT) From: Daniel Vetter To: LKML Date: Wed, 14 Aug 2019 22:20:27 +0200 Message-Id: <20190814202027.18735-6-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190814202027.18735-1-daniel.vetter@ffwll.ch> References: <20190814202027.18735-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8YdsxBm4SorcCs6LR7QkyWK07j5ac679kdHnkcCO8NA=; b=SElBQSnY/MEpHH8627z9LUJO0AwXfwMVSdTTj8+/meirzqVOVaUQig461Ql4grU9BW AVOrqu2gy8FVObWFxEJFZZI9KGDQ9zAPfmV41ZLckaSp17XA9+mEmzFQIBhzh/7c6swP BOywaRmA/1lgbIGeuvAe+e1TOiq/MWLuxLS1U= Subject: [Intel-gfx] [PATCH 5/5] mm/hmm: WARN on illegal ->sync_cpu_device_pagetables errors X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ralph Campbell , Andrew Morton , Arnd Bergmann , linux-mm@kvack.org, Daniel Vetter , Intel Graphics Development , DRI Development , Jason Gunthorpe , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Matthew Wilcox , John Hubbard , Daniel Vetter , Dan Williams , Ira Weiny , Balbir Singh , Dan Carpenter , Souptick Joarder Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Similar to the warning in the mmu notifer, warning if an hmm mirror callback gets it's blocking vs. nonblocking handling wrong, or if it fails with anything else than -EAGAIN. Cc: Jason Gunthorpe Cc: Ralph Campbell Cc: John Hubbard Cc: Dan Williams Cc: Dan Carpenter Cc: Matthew Wilcox Cc: Arnd Bergmann Cc: Balbir Singh Cc: Ira Weiny Cc: Souptick Joarder Cc: Andrew Morton Cc: "Jérôme Glisse" Cc: linux-mm@kvack.org Signed-off-by: Daniel Vetter Reviewed-by: Daniel Vetter --- mm/hmm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/hmm.c b/mm/hmm.c index 16b6731a34db..52ac59384268 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -205,6 +205,9 @@ static int hmm_invalidate_range_start(struct mmu_notifier *mn, ret = -EAGAIN; break; } + WARN(ret, "%pS callback failed with %d in %sblockable context\n", + mirror->ops->sync_cpu_device_pagetables, ret, + update.blockable ? "" : "non-"); } up_read(&hmm->mirrors_sem);