| Message ID | 20190815055550.1588-1-nishkadg.linux@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 67a53081e655d41a77f510377364600e5e9bf89c |
| Headers | show |
| Series | i2c: iproc: Make bcm_iproc_i2c_quirks constant | expand |
Hi Nishka, On 8/14/19 10:55 PM, Nishka Dasgupta wrote: > Static structure bcm_iproc_i2c_quirks, of type i2c_adapter_quirks, is > only used when being assigned to constant field quirks of a variable > having type i2c_adapter. Hence make bcm_iproc_i2c_quirks constant as > well to prevent it from unintended modification. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> > --- > drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c > index d7fd76baec92..e9f0e5b6eadc 100644 > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > @@ -805,7 +805,7 @@ static struct i2c_algorithm bcm_iproc_algo = { > .unreg_slave = bcm_iproc_i2c_unreg_slave, > }; > > -static struct i2c_adapter_quirks bcm_iproc_i2c_quirks = { > +static const struct i2c_adapter_quirks bcm_iproc_i2c_quirks = { > .max_read_len = M_RX_MAX_READ_LEN, > }; > > This looks good to me. Thanks! Reviewed-by: Ray Jui <ray.jui@broadcom.com>
diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index d7fd76baec92..e9f0e5b6eadc 100644 --- a/drivers/i2c/busses/i2c-bcm-iproc.c +++ b/drivers/i2c/busses/i2c-bcm-iproc.c @@ -805,7 +805,7 @@ static struct i2c_algorithm bcm_iproc_algo = { .unreg_slave = bcm_iproc_i2c_unreg_slave, }; -static struct i2c_adapter_quirks bcm_iproc_i2c_quirks = { +static const struct i2c_adapter_quirks bcm_iproc_i2c_quirks = { .max_read_len = M_RX_MAX_READ_LEN, };
Static structure bcm_iproc_i2c_quirks, of type i2c_adapter_quirks, is only used when being assigned to constant field quirks of a variable having type i2c_adapter. Hence make bcm_iproc_i2c_quirks constant as well to prevent it from unintended modification. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> --- drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)