| Message ID | 20190815055857.1944-1-nishkadg.linux@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 2252c3172cc5ecfab5aef1057f7c57b39e485f21 |
| Headers | show |
| Series | i2c: stm32f7: Make structure stm32f7_i2c_algo constant | expand |
On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote: > Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only > when it is assigned to constant field algo of a variable having type > i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it > const as well to protect it from unintended modification. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> > --- Are you guys okay with this patch? > drivers/i2c/busses/i2c-stm32f7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index 266d1c269b83..d36cf08461f7 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap) > I2C_FUNC_SMBUS_I2C_BLOCK; > } > > -static struct i2c_algorithm stm32f7_i2c_algo = { > +static const struct i2c_algorithm stm32f7_i2c_algo = { > .master_xfer = stm32f7_i2c_xfer, > .smbus_xfer = stm32f7_i2c_smbus_xfer, > .functionality = stm32f7_i2c_func, > -- > 2.19.1 >
Hi Wolfram Sorry for the delay. Acked-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com> BR On 9/3/19 8:05 PM, Wolfram Sang wrote: > On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote: >> Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only >> when it is assigned to constant field algo of a variable having type >> i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it >> const as well to protect it from unintended modification. >> Issue found with Coccinelle. >> >> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> >> --- > > Are you guys okay with this patch? > >> drivers/i2c/busses/i2c-stm32f7.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c >> index 266d1c269b83..d36cf08461f7 100644 >> --- a/drivers/i2c/busses/i2c-stm32f7.c >> +++ b/drivers/i2c/busses/i2c-stm32f7.c >> @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap) >> I2C_FUNC_SMBUS_I2C_BLOCK; >> } >> >> -static struct i2c_algorithm stm32f7_i2c_algo = { >> +static const struct i2c_algorithm stm32f7_i2c_algo = { >> .master_xfer = stm32f7_i2c_xfer, >> .smbus_xfer = stm32f7_i2c_smbus_xfer, >> .functionality = stm32f7_i2c_func, >> -- >> 2.19.1 >>
On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote: > Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only > when it is assigned to constant field algo of a variable having type > i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it > const as well to protect it from unintended modification. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index 266d1c269b83..d36cf08461f7 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap) I2C_FUNC_SMBUS_I2C_BLOCK; } -static struct i2c_algorithm stm32f7_i2c_algo = { +static const struct i2c_algorithm stm32f7_i2c_algo = { .master_xfer = stm32f7_i2c_xfer, .smbus_xfer = stm32f7_i2c_smbus_xfer, .functionality = stm32f7_i2c_func,
Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only when it is assigned to constant field algo of a variable having type i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it const as well to protect it from unintended modification. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> --- drivers/i2c/busses/i2c-stm32f7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)