[linux-next] qcom: qcs404: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404
diff mbox series

Message ID 20190815074848.195806-1-maowenan@huawei.com
State Not Applicable, archived
Headers show
Series
  • [linux-next] qcom: qcs404: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404
Related show

Commit Message

Mao Wenan Aug. 15, 2019, 7:48 a.m. UTC
There is one compilation error when CONFIG_INTERCONNECT_QCOM_QCS404=y and
CONFIG_INTERCONNECT_QCOM_SMD_RPM=y, as well as CONFIG_COMPILE_TEST=y,
but CONFIG_QCOM_SMD_RPM is not set, logs as below:

drivers/interconnect/qcom/smd-rpm.o: In function `qcom_icc_rpm_smd_send':
smd-rpm.c:(.text+0xe4): undefined reference to `qcom_rpm_smd_write'
Makefile:1071: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1

This is because
INTERCONNECT_QCOM_QCS404 depends on QCOM_SMD_RPM || COMPILE_TEST.
Here CONFIG_COMPILE_TEST=y, so CONFIG_INTERCONNECT_QCOM_SMD_RPM
is selected. If CONFIG_QCOM_SMD_RPM is not set, then
qcom_rpm_smd_write() is not defined, and compilation error happen.
Fix this by removing COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404.

Fixes: 5e4e6c4d3ae0 ("interconnect: qcom: Add QCS404 interconnect provider driver")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 drivers/interconnect/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd Aug. 18, 2019, 1:09 a.m. UTC | #1
Quoting Mao Wenan (2019-08-15 00:48:48)
> There is one compilation error when CONFIG_INTERCONNECT_QCOM_QCS404=y and
> CONFIG_INTERCONNECT_QCOM_SMD_RPM=y, as well as CONFIG_COMPILE_TEST=y,
> but CONFIG_QCOM_SMD_RPM is not set, logs as below:
> 
> drivers/interconnect/qcom/smd-rpm.o: In function `qcom_icc_rpm_smd_send':
> smd-rpm.c:(.text+0xe4): undefined reference to `qcom_rpm_smd_write'
> Makefile:1071: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> This is because
> INTERCONNECT_QCOM_QCS404 depends on QCOM_SMD_RPM || COMPILE_TEST.
> Here CONFIG_COMPILE_TEST=y, so CONFIG_INTERCONNECT_QCOM_SMD_RPM
> is selected. If CONFIG_QCOM_SMD_RPM is not set, then
> qcom_rpm_smd_write() is not defined, and compilation error happen.
> Fix this by removing COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404.

Can you fix the actual problem with compile testing this driver vs. just
removing the possibility to compile test. Otherwise it gives up on
the spirit of the idea of COMPILE_TEST.
Mao Wenan Aug. 19, 2019, 1:31 a.m. UTC | #2
On 2019/8/18 9:09, Stephen Boyd wrote:
> Quoting Mao Wenan (2019-08-15 00:48:48)
>> There is one compilation error when CONFIG_INTERCONNECT_QCOM_QCS404=y and
>> CONFIG_INTERCONNECT_QCOM_SMD_RPM=y, as well as CONFIG_COMPILE_TEST=y,
>> but CONFIG_QCOM_SMD_RPM is not set, logs as below:
>>
>> drivers/interconnect/qcom/smd-rpm.o: In function `qcom_icc_rpm_smd_send':
>> smd-rpm.c:(.text+0xe4): undefined reference to `qcom_rpm_smd_write'
>> Makefile:1071: recipe for target 'vmlinux' failed
>> make: *** [vmlinux] Error 1
>>
>> This is because
>> INTERCONNECT_QCOM_QCS404 depends on QCOM_SMD_RPM || COMPILE_TEST.
>> Here CONFIG_COMPILE_TEST=y, so CONFIG_INTERCONNECT_QCOM_SMD_RPM
>> is selected. If CONFIG_QCOM_SMD_RPM is not set, then
>> qcom_rpm_smd_write() is not defined, and compilation error happen.
>> Fix this by removing COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404.
> 
> Can you fix the actual problem with compile testing this driver vs. just
> removing the possibility to compile test. Otherwise it gives up on
> the spirit of the idea of COMPILE_TEST.

yes, I have already tried to move COMPILE_TEST to INTERCONNECT_QCOM,


 config INTERCONNECT_QCOM
        bool "Qualcomm Network-on-Chip interconnect drivers"
-       depends on ARCH_QCOM
+       depends on ARCH_QCOM || COMPILE_TEST
        help
          Support for Qualcomm's Network-on-Chip interconnect hardware.

> 
> 
> .
>

Patch
diff mbox series

diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
index 339e8f1..6ab4012 100644
--- a/drivers/interconnect/qcom/Kconfig
+++ b/drivers/interconnect/qcom/Kconfig
@@ -8,7 +8,7 @@  config INTERCONNECT_QCOM
 config INTERCONNECT_QCOM_QCS404
 	tristate "Qualcomm QCS404 interconnect driver"
 	depends on INTERCONNECT_QCOM
-	depends on QCOM_SMD_RPM || COMPILE_TEST
+	depends on QCOM_SMD_RPM
 	select INTERCONNECT_QCOM_SMD_RPM
 	help
 	  This is a driver for the Qualcomm Network-on-Chip on qcs404-based