| Message ID | 1565940916012.8169@bt.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Invert Endian bit in SPARCv9 MMU TTE | expand |
On 8/16/19 9:35 AM, tony.nguyen@bt.com wrote: > For each device declared with DEVICE_NATIVE_ENDIAN, find the set of > targets from the set of target/hw/*/device.o. > > If the set of targets are all little or all big endian, re-declare > the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN > respectively. > > This *naive* deduction may result in genuinely native endian devices > being incorrectly declared as little or big endian, but should not > introduce regressions for current targets. > > These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it > has a new target with an opposite endian or 2) someone informed knows > better =) > > Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> > --- > hw/pci-host/q35.c | 2 +- > hw/pci-host/versatile.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c > index 0a010be..fd20f72 100644 > --- a/hw/pci-host/q35.c > +++ b/hw/pci-host/q35.c > @@ -288,7 +288,7 @@ static void tseg_blackhole_write(void *opaque, > hwaddr addr, uint64_t val, > static const MemoryRegionOps tseg_blackhole_ops = { > .read = tseg_blackhole_read, > .write = tseg_blackhole_write, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, OK. > .valid.min_access_size = 1, > .valid.max_access_size = 4, > .impl.min_access_size = 4, > diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c > index 791b321..e7017f3 100644 > --- a/hw/pci-host/versatile.c > +++ b/hw/pci-host/versatile.c > @@ -240,7 +240,7 @@ static uint64_t pci_vpb_reg_read(void *opaque, > hwaddr addr, > static const MemoryRegionOps pci_vpb_reg_ops = { > .read = pci_vpb_reg_read, > .write = pci_vpb_reg_write, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, > .valid = { > .min_access_size = 4, > .max_access_size = 4, > @@ -306,7 +306,7 @@ static uint64_t pci_vpb_config_read(void *opaque, > hwaddr addr, > static const MemoryRegionOps pci_vpb_config_ops = { > .read = pci_vpb_config_read, > .write = pci_vpb_config_write, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, Eh hard to say, PCI is not clear about endianess... > }; > > static int pci_vpb_map_irq(PCIDevice *d, int irq_num) > -- > 1.8.3.1 > > > >
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 0a010be..fd20f72 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -288,7 +288,7 @@ static void tseg_blackhole_write(void *opaque, hwaddr addr, uint64_t val, static const MemoryRegionOps tseg_blackhole_ops = { .read = tseg_blackhole_read, .write = tseg_blackhole_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid.min_access_size = 1, .valid.max_access_size = 4, .impl.min_access_size = 4, diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c index 791b321..e7017f3 100644 --- a/hw/pci-host/versatile.c +++ b/hw/pci-host/versatile.c @@ -240,7 +240,7 @@ static uint64_t pci_vpb_reg_read(void *opaque, hwaddr addr, static const MemoryRegionOps pci_vpb_reg_ops = { .read = pci_vpb_reg_read, .write = pci_vpb_reg_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, @@ -306,7 +306,7 @@ static uint64_t pci_vpb_config_read(void *opaque, hwaddr addr, static const MemoryRegionOps pci_vpb_config_ops = { .read = pci_vpb_config_read, .write = pci_vpb_config_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static int pci_vpb_map_irq(PCIDevice *d, int irq_num)
For each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o. If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively. This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets. These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =) Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> --- hw/pci-host/q35.c | 2 +- hw/pci-host/versatile.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 1.8.3.1 ?