ARM: dts: logicpd-torpedo-som: Remove twl_keypad
diff mbox series

Message ID 20190816225812.14301-1-aford173@gmail.com
State New
Headers show
Series
  • ARM: dts: logicpd-torpedo-som: Remove twl_keypad
Related show

Commit Message

Adam Ford Aug. 16, 2019, 10:58 p.m. UTC
The TWL4030 used on the Logit PD Torpedo SOM does not have the
keypad pins routed.  This patch disables the twl_keypad driver
to remove some splat during boot:

[    5.902221] twl4030_keypad 48070000.i2c:twl@48:keypad: missing or malformed property linux,keymap: -22
[    5.911773] twl4030_keypad 48070000.i2c:twl@48:keypad: Failed to build keymap
[    5.918975] twl4030_keypad: probe of 48070000.i2c:twl@48:keypad failed with error -22

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Adam Ford Oct. 3, 2019, 11:33 p.m. UTC | #1
On Fri, Aug 16, 2019 at 5:58 PM Adam Ford <aford173@gmail.com> wrote:
>
> The TWL4030 used on the Logit PD Torpedo SOM does not have the
> keypad pins routed.  This patch disables the twl_keypad driver
> to remove some splat during boot:
>
> [    5.902221] twl4030_keypad 48070000.i2c:twl@48:keypad: missing or malformed property linux,keymap: -22
> [    5.911773] twl4030_keypad 48070000.i2c:twl@48:keypad: Failed to build keymap
> [    5.918975] twl4030_keypad: probe of 48070000.i2c:twl@48:keypad failed with error -22
>
> Signed-off-by: Adam Ford <aford173@gmail.com>

Tony,

Any chance this can get accepted?

adam
>
> diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> index 3fdd0a72f87f..506b118e511a 100644
> --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> @@ -192,3 +192,7 @@
>  &twl_gpio {
>         ti,use-leds;
>  };
> +
> +&twl_keypad {
> +       status = "disabled";
> +};
> --
> 2.17.1
>
Tony Lindgren Oct. 4, 2019, 4:10 p.m. UTC | #2
* Adam Ford <aford173@gmail.com> [191003 23:33]:
> On Fri, Aug 16, 2019 at 5:58 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > The TWL4030 used on the Logit PD Torpedo SOM does not have the
> > keypad pins routed.  This patch disables the twl_keypad driver
> > to remove some splat during boot:
> >
> > [    5.902221] twl4030_keypad 48070000.i2c:twl@48:keypad: missing or malformed property linux,keymap: -22
> > [    5.911773] twl4030_keypad 48070000.i2c:twl@48:keypad: Failed to build keymap
> > [    5.918975] twl4030_keypad: probe of 48070000.i2c:twl@48:keypad failed with error -22
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> Tony,
> 
> Any chance this can get accepted?

Yeah sure, I was thinking it for v5.5, but since  it's a one liner and
removes few lines of bogus warnings I'm applying it into fixes instead
of next.

Thanks,

Tony

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
index 3fdd0a72f87f..506b118e511a 100644
--- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
+++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
@@ -192,3 +192,7 @@ 
 &twl_gpio {
 	ti,use-leds;
 };
+
+&twl_keypad {
+	status = "disabled";
+};