[RFC,2/5] line-log: remove unused fields from 'struct line_log_data'
diff mbox series

Message ID 20190818182801.7580-3-szeder.dev@gmail.com
State New
Headers show
Series
  • line-log: towards a more responsive, incremental 'git log -L'
Related show

Commit Message

SZEDER Gábor Aug. 18, 2019, 6:27 p.m. UTC
Remove the unused fields 'status', 'arg_alloc', 'arg_nr' and 'args'
from 'struct line_log_data'.  They were already part of the struct
when it was introduced in commit 12da1d1f6 (Implement line-history
search (git log -L), 2013-03-28), but as far as I can tell none of
them have ever been actually used.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 line-log.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Derrick Stolee Aug. 19, 2019, 11:53 a.m. UTC | #1
On 8/18/2019 2:27 PM, SZEDER Gábor wrote:
> Remove the unused fields 'status', 'arg_alloc', 'arg_nr' and 'args'
> from 'struct line_log_data'.  They were already part of the struct
> when it was introduced in commit 12da1d1f6 (Implement line-history
> search (git log -L), 2013-03-28), but as far as I can tell none of
> them have ever been actually used.

Good cleanup! 

-Stolee

Patch
diff mbox series

diff --git a/line-log.h b/line-log.h
index 8ee7a2bd4a..882c5055bb 100644
--- a/line-log.h
+++ b/line-log.h
@@ -46,10 +46,7 @@  void sort_and_merge_range_set(struct range_set *);
 struct line_log_data {
 	struct line_log_data *next;
 	char *path;
-	char status;
 	struct range_set ranges;
-	int arg_alloc, arg_nr;
-	const char **args;
 	struct diff_filepair *pair;
 	struct diff_ranges diff;
 };