diff mbox series

platform: x86: pcengines-apuv2: detect apuv4 board

Message ID 1566294992-703-1-git-send-email-info@metux.net (mailing list archive)
State Changes Requested, archived
Delegated to: Andy Shevchenko
Headers show
Series platform: x86: pcengines-apuv2: detect apuv4 board | expand

Commit Message

Enrico Weigelt, metux IT consult Aug. 20, 2019, 9:56 a.m. UTC 
GPIO stuff on APUv4 seems to be the same as on APUv2, so we just
need to match on DMI data.

Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
---
 drivers/platform/x86/pcengines-apuv2.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Comments

Andy Shevchenko Aug. 22, 2019, 7:47 p.m. UTC | #1 
On Tue, Aug 20, 2019 at 12:56 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> GPIO stuff on APUv4 seems to be the same as on APUv2, so we just
> need to match on DMI data.
>

> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe

Wrong format.

W/o SoB tag I can't take it.
Enrico Weigelt, metux IT consult Aug. 28, 2019, 11:37 a.m. UTC | #2 
On 22.08.19 21:47, Andy Shevchenko wrote:

>> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
> 
> Wrong format.
> 
> W/o SoB tag I can't take it.

What's the correct format (what command shall I use to
create it correctly ?)


--mtx
Andy Shevchenko Sept. 7, 2019, 5:31 p.m. UTC | #3 
On Wed, Aug 28, 2019 at 2:37 PM Enrico Weigelt, metux IT consult
<lkml@metux.net> wrote:
>
> On 22.08.19 21:47, Andy Shevchenko wrote:
>
> >> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
> >
> > Wrong format.
> >
> > W/o SoB tag I can't take it.
>
> What's the correct format (what command shall I use to
> create it correctly ?)

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Section 11

And for this one Fixes is not needed. The APUv4 never worked before, correct?
diff mbox series

Patch

diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index e4c68ef..ea0c6bb 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -178,6 +178,33 @@ 
 		},
 		.driver_data = (void *)&board_apu2,
 	},
+	/* APU4 w/ legacy bios < 4.0.8 */
+	{
+		.ident        = "apu4",
+		.matches    = {
+			DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+			DMI_MATCH(DMI_BOARD_NAME, "APU4")
+		},
+		.driver_data = (void *)&board_apu2,
+	},
+	/* APU4 w/ legacy bios >= 4.0.8 */
+	{
+		.ident       = "apu4",
+		.matches     = {
+			DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+			DMI_MATCH(DMI_BOARD_NAME, "apu4")
+		},
+		.driver_data = (void *)&board_apu2,
+	},
+	/* APU4 w/ mainline bios */
+	{
+		.ident       = "apu4",
+		.matches     = {
+			DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+			DMI_MATCH(DMI_BOARD_NAME, "PC Engines apu4")
+		},
+		.driver_data = (void *)&board_apu2,
+	},
 	{}
 };