| Message ID | 20190820130634.25954-2-riteshh@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ext4: bmap & fiemap conversion to use iomap | expand |
On Tue 20-08-19 18:36:33, Ritesh Harjani wrote: > ext4_iomap_begin is already implemented which provides > ext4_map_blocks, so just move the API from > generic_block_bmap to iomap_bmap for iomap conversion. > > Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> This seems to have fallen through the cracks. The patch looks OK, feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/ext4/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 420fe3deed39..d6a34214e9df 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3355,7 +3355,7 @@ static sector_t ext4_bmap(struct address_space *mapping, sector_t block) > return 0; > } > > - return generic_block_bmap(mapping, block, ext4_get_block); > + return iomap_bmap(mapping, block, &ext4_iomap_ops); > } > > static int ext4_readpage(struct file *file, struct page *page) > -- > 2.21.0 >
On 10/16/19 2:01 PM, Jan Kara wrote: > On Tue 20-08-19 18:36:33, Ritesh Harjani wrote: >> ext4_iomap_begin is already implemented which provides >> ext4_map_blocks, so just move the API from >> generic_block_bmap to iomap_bmap for iomap conversion. >> >> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> > > This seems to have fallen through the cracks. The patch looks OK, feel free > to add: Np. Thanks for the review :) > > Reviewed-by: Jan Kara <jack@suse.cz> > > Honza > >> --- >> fs/ext4/inode.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c >> index 420fe3deed39..d6a34214e9df 100644 >> --- a/fs/ext4/inode.c >> +++ b/fs/ext4/inode.c >> @@ -3355,7 +3355,7 @@ static sector_t ext4_bmap(struct address_space *mapping, sector_t block) >> return 0; >> } >> >> - return generic_block_bmap(mapping, block, ext4_get_block); >> + return iomap_bmap(mapping, block, &ext4_iomap_ops); >> } >> >> static int ext4_readpage(struct file *file, struct page *page) >> -- >> 2.21.0 >>
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 420fe3deed39..d6a34214e9df 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3355,7 +3355,7 @@ static sector_t ext4_bmap(struct address_space *mapping, sector_t block) return 0; } - return generic_block_bmap(mapping, block, ext4_get_block); + return iomap_bmap(mapping, block, &ext4_iomap_ops); } static int ext4_readpage(struct file *file, struct page *page)
ext4_iomap_begin is already implemented which provides ext4_map_blocks, so just move the API from generic_block_bmap to iomap_bmap for iomap conversion. Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> --- fs/ext4/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)