From patchwork Tue Aug 20 19:54:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11104565 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D70E0174A for ; Tue, 20 Aug 2019 19:55:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEEA920C01 for ; Tue, 20 Aug 2019 19:55:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEEA920C01 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AC4C88970B; Tue, 20 Aug 2019 19:54:59 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AB448966B for ; Tue, 20 Aug 2019 19:54:58 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id t50so128926edd.2 for ; Tue, 20 Aug 2019 12:54:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JS1RHTkJnaQCaYGVbIEVnObAwd1uiUZ/ycHUm8EAhlo=; b=DDysQvGl1gEJ9shAhZsWyQ7bmMeS2OqhVYWbs5KfYlnJ0F3AOFAjGZM4hErAcQg0S2 srtSRg9Hp8XGS1P24GdfqHU2eaiZclY0+9xEl534D8cS7Vji+ALIU9g4fkrwiYLcF34r phWQIGaBk6bl8CNCsT7ZvLl4oXW5B0u735xMaRCJD6r2aR3dZHr36AYenydxcyK547Ln eTFJ5H3joITroBimAgAL65IA7o2R45fqtuQFX0//Ts/pr5g+kNRB3G7WnsOktQ2FOFfy sLh4TaF19onGUc1qPlzYHm/eNCm14aGUTzl8vDAQFtmk8ahxjGnGJUipIeor7+EJRXEr RYVA== X-Gm-Message-State: APjAAAU1XLS0TTDQ0b8fRi7/hjrQTDwT00/QjEpHXt3ghKIXEv+IIVNt Vxxqd7tPaG2uWXAv5NceDAkrWk4J+xFp/Q== X-Google-Smtp-Source: APXvYqxwt34OvtLcZyA8ICCphauaOLOPdr2SKjnwZTfDGeSMZiMxKLaEs/FO0QlT+rtmf/VjxAOdiA== X-Received: by 2002:aa7:d5d3:: with SMTP id d19mr33979582eds.103.1566330896526; Tue, 20 Aug 2019 12:54:56 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id k12sm2782436ejz.79.2019.08.20.12.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 12:54:55 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Tue, 20 Aug 2019 21:54:51 +0200 Message-Id: <20190820195451.15671-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20190820170631.26570-1-daniel.vetter@ffwll.ch> References: <20190820170631.26570-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JS1RHTkJnaQCaYGVbIEVnObAwd1uiUZ/ycHUm8EAhlo=; b=DRyLzsiwI0HUZ9aD6ifd5Wbgz7Oir3Y2EbI+JodT1DYrA/HcYCarioNeL3SXDAgDrh jtlwVLPDi/nx9nRvjLa6k0k1MwMM717DOfdUdSVyfrgbMK6Wzkpdgr/PZ3BsBn8holdD spLQeb630CpYZpDwwLFHqY1XCHGPOkqU52TXs= Subject: [Intel-gfx] [PATCH] drm/i915: disable set/get_tiling ioctl on gen12+ X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Lucas De Marchi , Kenneth Graunke , Matthew Auld , Daniel Vetter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" The cpu (de)tiler hw is gone, this stopped being useful. Plus it never supported any of the fancy new tiling formats, which means userspace also stopped using the magic side-channel this provides. This would totally break a lot of the igts, but they're already broken for the same reasons as userspace on gen12 would be. v2: Look at ggtt->num_fences instead, that also avoids the need for a comment (Chris). This also means that gen12 support really needs to make sure num_fences is set to 0. There is a patch for that, but it checks for HAS_MAPPABLE_APERTURE, which I'm not sure is the right thing really. Adding relevant people. Cc: Daniele Ceraolo Spurio Cc: Stuart Summers Cc: Matthew Auld Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Chris Wilson Cc: Lucas De Marchi Signed-off-by: Daniel Vetter Acked-by: Jason Ekstrand Reviewed-by: José Roberto de Souza Reviewed-by: José Roberto de Souza --- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c index ca0c2f451742..e5d1ae8d4dba 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c @@ -313,10 +313,14 @@ int i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data, struct drm_file *file) { + struct drm_i915_private *dev_priv = to_i915(dev); struct drm_i915_gem_set_tiling *args = data; struct drm_i915_gem_object *obj; int err; + if (!dev_priv->ggtt.num_fences) + return -EOPNOTSUPP; + obj = i915_gem_object_lookup(file, args->handle); if (!obj) return -ENOENT; @@ -402,6 +406,9 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data, struct drm_i915_gem_object *obj; int err = -ENOENT; + if (!dev_priv->ggtt.num_fences) + return -EOPNOTSUPP; + rcu_read_lock(); obj = i915_gem_object_lookup_rcu(file, args->handle); if (obj) {