[2/3] btrfs: dev stats item key conversion per cpu type is not needed
diff mbox series

Message ID 20190821092634.6778-2-anand.jain@oracle.com
State New
Headers show
Series
  • [1/3] btrfs: dev stat drop useless goto
Related show

Commit Message

Anand Jain Aug. 21, 2019, 9:26 a.m. UTC
%found_key is not used, drop it.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 fs/btrfs/volumes.c | 2 --
 1 file changed, 2 deletions(-)

Comments

David Sterba Aug. 21, 2019, 1:51 p.m. UTC | #1
On Wed, Aug 21, 2019 at 05:26:33PM +0800, Anand Jain wrote:
> %found_key is not used, drop it.

Patches that remove dead/unused code should say why, eg. in this case
the variable hasn't been used since the beginning, but in other cases it
may point to code that needs closer attention.

Patch
diff mbox series

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index bd279db0f760..a343aa9cf5ba 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -7278,7 +7278,6 @@  void btrfs_init_devices_late(struct btrfs_fs_info *fs_info)
 int btrfs_init_dev_stats(struct btrfs_fs_info *fs_info)
 {
 	struct btrfs_key key;
-	struct btrfs_key found_key;
 	struct btrfs_root *dev_root = fs_info->dev_root;
 	struct btrfs_fs_devices *fs_devices = fs_info->fs_devices;
 	struct extent_buffer *eb;
@@ -7310,7 +7309,6 @@  int btrfs_init_dev_stats(struct btrfs_fs_info *fs_info)
 		}
 		slot = path->slots[0];
 		eb = path->nodes[0];
-		btrfs_item_key_to_cpu(eb, &found_key, slot);
 		item_size = btrfs_item_size_nr(eb, slot);
 
 		ptr = btrfs_item_ptr(eb, slot,