| Message ID | 1566480139-4015-1-git-send-email-martepisa@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: imu: st_lsm6dsx: Fix FIFO diff mask for tagged fifo | expand |
On Thu, 22 Aug 2019 15:22:19 +0200 Mario Tesi <martepisa@gmail.com> wrote: > From: mario tesi <mario.tesi@st.com> > > According to the latest version of datasheet the mask > for number of unread sensor data in FIFO_STATUS registers > has been extended to 10 bits > > The devices involved are: > - LSM6DSO > - LSM6DSOX > - ASM330LHH > - LSM6DSR > - ISM330DHCX > > Signed-off-by: mario tesi <mario.tesi@st.com> Seems straight forward and should be side effect free I think. Hence I won't wait for Lorenzo to take a look (though there is still a small window for comments whilst the autobuilders poke at it!) Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to take a look. Thanks, Jonathan > --- > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > index 85824d6..47b77d0 100644 > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > @@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > }, > .fifo_diff = { > .addr = 0x3a, > - .mask = GENMASK(8, 0), > + .mask = GENMASK(9, 0), > }, > .th_wl = 1, > }, > @@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > }, > .fifo_diff = { > .addr = 0x3a, > - .mask = GENMASK(8, 0), > + .mask = GENMASK(9, 0), > }, > .th_wl = 1, > }, > @@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > }, > .fifo_diff = { > .addr = 0x3a, > - .mask = GENMASK(8, 0), > + .mask = GENMASK(9, 0), > }, > .th_wl = 1, > },
> On Thu, 22 Aug 2019 15:22:19 +0200 > Mario Tesi <martepisa@gmail.com> wrote: > > > From: mario tesi <mario.tesi@st.com> > > > > According to the latest version of datasheet the mask > > for number of unread sensor data in FIFO_STATUS registers > > has been extended to 10 bits > > > > The devices involved are: > > - LSM6DSO > > - LSM6DSOX > > - ASM330LHH > > - LSM6DSR > > - ISM330DHCX > > > > Signed-off-by: mario tesi <mario.tesi@st.com> > > Seems straight forward and should be side effect free I think. > Hence I won't wait for Lorenzo to take a look (though there > is still a small window for comments whilst the autobuilders > poke at it!) > > Applied to the togreg branch of iio.git and pushed out as testing > for the autobuilders to take a look. > > Thanks, Acked-by: Lorenzo Bianconi <lorenzo@kernel.org> > > Jonathan > > > --- > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > index 85824d6..47b77d0 100644 > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > @@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > }, > > .fifo_diff = { > > .addr = 0x3a, > > - .mask = GENMASK(8, 0), > > + .mask = GENMASK(9, 0), > > }, > > .th_wl = 1, > > }, > > @@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > }, > > .fifo_diff = { > > .addr = 0x3a, > > - .mask = GENMASK(8, 0), > > + .mask = GENMASK(9, 0), > > }, > > .th_wl = 1, > > }, > > @@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > }, > > .fifo_diff = { > > .addr = 0x3a, > > - .mask = GENMASK(8, 0), > > + .mask = GENMASK(9, 0), > > }, > > .th_wl = 1, > > }, >
On Mon, 26 Aug 2019 10:22:20 +0200 Lorenzo Bianconi <lorenzo@kernel.org> wrote: > > On Thu, 22 Aug 2019 15:22:19 +0200 > > Mario Tesi <martepisa@gmail.com> wrote: > > > > > From: mario tesi <mario.tesi@st.com> > > > > > > According to the latest version of datasheet the mask > > > for number of unread sensor data in FIFO_STATUS registers > > > has been extended to 10 bits > > > > > > The devices involved are: > > > - LSM6DSO > > > - LSM6DSOX > > > - ASM330LHH > > > - LSM6DSR > > > - ISM330DHCX > > > > > > Signed-off-by: mario tesi <mario.tesi@st.com> > > > > Seems straight forward and should be side effect free I think. > > Hence I won't wait for Lorenzo to take a look (though there > > is still a small window for comments whilst the autobuilders > > poke at it!) > > > > Applied to the togreg branch of iio.git and pushed out as testing > > for the autobuilders to take a look. > > > > Thanks, > > Acked-by: Lorenzo Bianconi <lorenzo@kernel.org> Nice. That was fast enough that I haven't applied any patches on top of Mario's yet so a quick git --amend job ;) Thanks, Jonathan > > > > > Jonathan > > > > > --- > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > index 85824d6..47b77d0 100644 > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > @@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > }, > > > .fifo_diff = { > > > .addr = 0x3a, > > > - .mask = GENMASK(8, 0), > > > + .mask = GENMASK(9, 0), > > > }, > > > .th_wl = 1, > > > }, > > > @@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > }, > > > .fifo_diff = { > > > .addr = 0x3a, > > > - .mask = GENMASK(8, 0), > > > + .mask = GENMASK(9, 0), > > > }, > > > .th_wl = 1, > > > }, > > > @@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > }, > > > .fifo_diff = { > > > .addr = 0x3a, > > > - .mask = GENMASK(8, 0), > > > + .mask = GENMASK(9, 0), > > > }, > > > .th_wl = 1, > > > }, > >
diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index 85824d6..47b77d0 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { }, .fifo_diff = { .addr = 0x3a, - .mask = GENMASK(8, 0), + .mask = GENMASK(9, 0), }, .th_wl = 1, }, @@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { }, .fifo_diff = { .addr = 0x3a, - .mask = GENMASK(8, 0), + .mask = GENMASK(9, 0), }, .th_wl = 1, }, @@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { }, .fifo_diff = { .addr = 0x3a, - .mask = GENMASK(8, 0), + .mask = GENMASK(9, 0), }, .th_wl = 1, },