| Message ID | 20190823151618.13904-1-vidyas@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI: dwc: Use dev_info() instead of dev_err() | expand |
On Fri, Aug 23, 2019 at 08:46:18PM +0530, Vidya Sagar wrote: > When a platform has an open PCIe slot, not having a device connected to > it doesn't have to result in a dev_err() print saying that the link is > not up but a dev_info() would suffice. > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > --- > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Squashed in pci/tegra, thanks. Lorenzo > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index 59eaeeb21dbe..4d6690b6ca36 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci) > usleep_range(LINK_WAIT_USLEEP_MIN, LINK_WAIT_USLEEP_MAX); > } > > - dev_err(pci->dev, "Phy link never came up\n"); > + dev_info(pci->dev, "Phy link never came up\n"); > > return -ETIMEDOUT; > } > -- > 2.17.1 >
On 23/08/2019 16:16, Vidya Sagar wrote: > When a platform has an open PCIe slot, not having a device connected to > it doesn't have to result in a dev_err() print saying that the link is > not up but a dev_info() would suffice. > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > --- > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index 59eaeeb21dbe..4d6690b6ca36 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci) > usleep_range(LINK_WAIT_USLEEP_MIN, LINK_WAIT_USLEEP_MAX); > } > > - dev_err(pci->dev, "Phy link never came up\n"); > + dev_info(pci->dev, "Phy link never came up\n"); IMO this message is not very descriptive. Why not just say 'no device connected'? From the changelog it is clear what this means but the message itself could be clearer. Or should it even be a dev_dbg? Cheers Jon
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index 59eaeeb21dbe..4d6690b6ca36 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci) usleep_range(LINK_WAIT_USLEEP_MIN, LINK_WAIT_USLEEP_MAX); } - dev_err(pci->dev, "Phy link never came up\n"); + dev_info(pci->dev, "Phy link never came up\n"); return -ETIMEDOUT; }
When a platform has an open PCIe slot, not having a device connected to it doesn't have to result in a dev_err() print saying that the link is not up but a dev_info() would suffice. Signed-off-by: Vidya Sagar <vidyas@nvidia.com> --- drivers/pci/controller/dwc/pcie-designware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)