diff mbox series

[v2,2/2] drm: rcar-du: kms: Expand comment in vsps parsing routine

Message ID 20190825140135.12150-3-jacopo+renesas@jmondi.org (mailing list archive)
State New
Delegated to: Kieran Bingham
Headers show
Series arm64: dts: renesas: Add LIF channel to 'vsps' property | expand

Commit Message

Jacopo Mondi Aug. 25, 2019, 2:01 p.m. UTC 
Exand comment in the 'vsps' parsing routine to specify why the LIF
channel index is defaulted to 0 in case the second cell of the property
is not specified.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

--
2.23.0

Comments

Laurent Pinchart Aug. 25, 2019, 6:06 p.m. UTC | #1 
Hi Jacopo,

Thank you for the patch.

How about changing the subject to "drm: rcar-du: Document DT backward
compatibility" ?

On Sun, Aug 25, 2019 at 04:01:35PM +0200, Jacopo Mondi wrote:
> Exand comment in the 'vsps' parsing routine to specify why the LIF

s/Exand/Expand/

> channel index is defaulted to 0 in case the second cell of the property

s/is defaulted to 0/defaults to 0/

> is not specified.

You could explain it here too :-)

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> index 2dc9caee8767..0d59f390de19 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -585,7 +585,11 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
> 
>  		vsps[j].crtcs_mask |= BIT(i);
> 
> -		/* Store the VSP pointer and pipe index in the CRTC. */
> +		/*
> +		 * Store the VSP pointer and pipe index in the CRTC. If the
> +		 * second cell of the 'vsps' specifier isn't present, default
> +		 * to 0 to remain compatible with older DT bindings.
> +		 */
>  		rcdu->crtcs[i].vsp = &rcdu->vsps[j];
>  		rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args[0] : 0;
>  	}
Jacopo Mondi Aug. 26, 2019, 7:23 a.m. UTC | #2 
Hi Laurent,

On Sun, Aug 25, 2019 at 09:06:03PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> How about changing the subject to "drm: rcar-du: Document DT backward
> compatibility" ?
>
> On Sun, Aug 25, 2019 at 04:01:35PM +0200, Jacopo Mondi wrote:
> > Exand comment in the 'vsps' parsing routine to specify why the LIF
>
> s/Exand/Expand/
>
> > channel index is defaulted to 0 in case the second cell of the property
>
> s/is defaulted to 0/defaults to 0/
>
> > is not specified.
>
> You could explain it here too :-)
>

Expand comment in the 'vsps' parsing routine to specify the LIF
channel index defaults to 0 in case the second cell of the property
is not specified to remain compatible with older DT bindings.

Could you take this in when applying this patch or want me to resend?

Thanks
  j


> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > ---
> >  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > index 2dc9caee8767..0d59f390de19 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > @@ -585,7 +585,11 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
> >
> >  		vsps[j].crtcs_mask |= BIT(i);
> >
> > -		/* Store the VSP pointer and pipe index in the CRTC. */
> > +		/*
> > +		 * Store the VSP pointer and pipe index in the CRTC. If the
> > +		 * second cell of the 'vsps' specifier isn't present, default
> > +		 * to 0 to remain compatible with older DT bindings.
> > +		 */
> >  		rcdu->crtcs[i].vsp = &rcdu->vsps[j];
> >  		rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args[0] : 0;
> >  	}
>
> --
> Regards,
>
> Laurent Pinchart
Laurent Pinchart Aug. 27, 2019, 1:23 p.m. UTC | #3 
Hi Jacopo,

On Mon, Aug 26, 2019 at 09:23:30AM +0200, Jacopo Mondi wrote:
> On Sun, Aug 25, 2019 at 09:06:03PM +0300, Laurent Pinchart wrote:
> > Hi Jacopo,
> >
> > Thank you for the patch.
> >
> > How about changing the subject to "drm: rcar-du: Document DT backward
> > compatibility" ?
> >
> > On Sun, Aug 25, 2019 at 04:01:35PM +0200, Jacopo Mondi wrote:
> >> Exand comment in the 'vsps' parsing routine to specify why the LIF
> >
> > s/Exand/Expand/
> >
> >> channel index is defaulted to 0 in case the second cell of the property
> >
> > s/is defaulted to 0/defaults to 0/
> >
> >> is not specified.
> >
> > You could explain it here too :-)
> 
> Expand comment in the 'vsps' parsing routine to specify the LIF
> channel index defaults to 0 in case the second cell of the property
> is not specified to remain compatible with older DT bindings.
> 
> Could you take this in when applying this patch or want me to resend?

I would have, but you have forgotten to CC the dri-devel mailing list
I'm afraid. Could you post a v3 of this patch to the list ? I'll then
pick it up.

> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> >> ---
> >>  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +++++-
> >>  1 file changed, 5 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> >> index 2dc9caee8767..0d59f390de19 100644
> >> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> >> @@ -585,7 +585,11 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
> >>
> >>  		vsps[j].crtcs_mask |= BIT(i);
> >>
> >> -		/* Store the VSP pointer and pipe index in the CRTC. */
> >> +		/*
> >> +		 * Store the VSP pointer and pipe index in the CRTC. If the
> >> +		 * second cell of the 'vsps' specifier isn't present, default
> >> +		 * to 0 to remain compatible with older DT bindings.
> >> +		 */
> >>  		rcdu->crtcs[i].vsp = &rcdu->vsps[j];
> >>  		rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args[0] : 0;
> >>  	}
diff mbox series

Patch

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 2dc9caee8767..0d59f390de19 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -585,7 +585,11 @@  static int rcar_du_vsps_init(struct rcar_du_device *rcdu)

 		vsps[j].crtcs_mask |= BIT(i);

-		/* Store the VSP pointer and pipe index in the CRTC. */
+		/*
+		 * Store the VSP pointer and pipe index in the CRTC. If the
+		 * second cell of the 'vsps' specifier isn't present, default
+		 * to 0 to remain compatible with older DT bindings.
+		 */
 		rcdu->crtcs[i].vsp = &rcdu->vsps[j];
 		rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args[0] : 0;
 	}